From owner-freebsd-firewire@FreeBSD.ORG  Thu Mar 22 16:22:00 2007
Return-Path: <owner-freebsd-firewire@FreeBSD.ORG>
X-Original-To: freebsd-firewire@freebsd.org
Delivered-To: freebsd-firewire@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 2E40E16A401
	for <freebsd-firewire@freebsd.org>;
	Thu, 22 Mar 2007 16:22:00 +0000 (UTC)
	(envelope-from freebsd@gm.nunu.org)
Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.184])
	by mx1.freebsd.org (Postfix) with ESMTP id BF7ED13C45D
	for <freebsd-firewire@freebsd.org>;
	Thu, 22 Mar 2007 16:21:59 +0000 (UTC)
	(envelope-from freebsd@gm.nunu.org)
Received: by nf-out-0910.google.com with SMTP id k27so1460315nfc
	for <freebsd-firewire@freebsd.org>;
	Thu, 22 Mar 2007 09:21:58 -0700 (PDT)
Received: by 10.78.185.16 with SMTP id i16mr1039329huf.1174580518515;
	Thu, 22 Mar 2007 09:21:58 -0700 (PDT)
Received: by 10.78.130.6 with HTTP; Thu, 22 Mar 2007 09:21:53 -0700 (PDT)
Message-ID: <626eb4530703220921p3f6176efxe2b8085724436afb@mail.gmail.com>
Date: Fri, 23 Mar 2007 01:21:53 +0900
From: "Hidetoshi Shimokawa" <simokawa@FreeBSD.ORG>
Sender: freebsd@gm.nunu.org
To: "Eric Anderson" <anderson@centtech.com>
In-Reply-To: <626eb4530703220845qdedffbdod4bd9894dec51e6@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <46028460.5000004@centtech.com>
	<626eb4530703220718q4d293a16wfbb0a70cf21e624b@mail.gmail.com>
	<46029A6E.9070000@centtech.com>
	<626eb4530703220845qdedffbdod4bd9894dec51e6@mail.gmail.com>
X-Google-Sender-Auth: fbe2e517d906f238
Cc: hopet@ics.muni.cz, freebsd-firewire@freebsd.org
Subject: Re: fwcontrol -R issues with several cameras
X-BeenThere: freebsd-firewire@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Firewire support in FreeBSD <freebsd-firewire.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-firewire>, 
	<mailto:freebsd-firewire-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-firewire>
List-Post: <mailto:freebsd-firewire@freebsd.org>
List-Help: <mailto:freebsd-firewire-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-firewire>, 
	<mailto:freebsd-firewire-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Mar 2007 16:22:00 -0000

Oops, I must be wrong.
Option '-M'  has to be used with '-R' .

On 3/23/07, Hidetoshi Shimokawa <simokawa@freebsd.org> wrote:
> I found a  trivial bug in fwcontrol.c for '-M' option.
>
> RCS file: /home/ncvs/src/usr.sbin/fwcontrol/fwcontrol.c,v retrieving
> revision 1.23
> diff -u -r1.23 fwcontrol.c
> --- fwcontrol.c 26 Oct 2006 22:33:38 -0000      1.23
> +++ fwcontrol.c 22 Mar 2007 15:37:25 -0000
> @@ -764,7 +764,7 @@
>                                 errx(EX_USAGE, "unrecognized method: %s",
>                                     optarg);
>                         }
> -                       break;
> +                       /* fall through */
>                 case 'R':
>                         open_dev(&fd, devbase);
>                         if (recvfn == NULL) /* guess... */
>
> Without this patch,  'fwcontrol -Md' will exit immediately.
> But I am not sure whether this fix your problem.

-- 
/\ Hidetoshi Shimokawa
\/  simokawa@FreeBSD.ORG