Date: Mon, 19 Jul 2010 08:29:21 -0400 From: John Baldwin <jhb@freebsd.org> To: Ivan Voras <ivoras@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r210217 - head/sys/kern Message-ID: <201007190829.21995.jhb@freebsd.org> In-Reply-To: <201007181015.o6IAFXvK018739@svn.freebsd.org> References: <201007181015.o6IAFXvK018739@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday, July 18, 2010 6:15:33 am Ivan Voras wrote: > Author: ivoras > Date: Sun Jul 18 10:15:33 2010 > New Revision: 210217 > URL: http://svn.freebsd.org/changeset/base/210217 > > Log: > In keeping with the Age-of-the-fruitbat theme, scale up hirunningspace on > machines which can clearly afford the memory. > > This is a somewhat conservative version of the patch - more fine tuning may be > necessary. > > Idea from: Thread on hackers@ > Discussed with: alc > > Modified: > head/sys/kern/vfs_bio.c > > Modified: head/sys/kern/vfs_bio.c > ============================================================================== > --- head/sys/kern/vfs_bio.c Sun Jul 18 08:54:31 2010 (r210216) > +++ head/sys/kern/vfs_bio.c Sun Jul 18 10:15:33 2010 (r210217) > @@ -621,7 +621,9 @@ bufinit(void) > lobufspace = hibufspace - MAXBSIZE; > > lorunningspace = 512 * 1024; > - hirunningspace = 1024 * 1024; > + hirunningspace = lmin(roundup(hibufspace/64, MAXBSIZE), 16*1024*1024); > + if (hirunningspace < 1024 * 1024) > + hirunningspace = 1024 * 1024; Presumably you could use 'lmax(lmin(..., 16 * 1024 * 1024), 1024 * 1024))'? Also, the common style throughout the kernel is to provide spaces around operators like '/' and '*'. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201007190829.21995.jhb>