From owner-svn-src-all@FreeBSD.ORG Tue Jul 20 13:03:35 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E63D3106567A; Tue, 20 Jul 2010 13:03:35 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id B71FA8FC23; Tue, 20 Jul 2010 13:03:35 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 4C96846B52; Tue, 20 Jul 2010 09:03:35 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id EE8548A03C; Tue, 20 Jul 2010 09:03:33 -0400 (EDT) From: John Baldwin To: Ivan Voras Date: Mon, 19 Jul 2010 08:29:21 -0400 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20100217; KDE/4.4.5; amd64; ; ) References: <201007181015.o6IAFXvK018739@svn.freebsd.org> In-Reply-To: <201007181015.o6IAFXvK018739@svn.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201007190829.21995.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Tue, 20 Jul 2010 09:03:33 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.0 required=4.2 tests=AWL,BAYES_00, DATE_IN_PAST_24_48 autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r210217 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jul 2010 13:03:36 -0000 On Sunday, July 18, 2010 6:15:33 am Ivan Voras wrote: > Author: ivoras > Date: Sun Jul 18 10:15:33 2010 > New Revision: 210217 > URL: http://svn.freebsd.org/changeset/base/210217 > > Log: > In keeping with the Age-of-the-fruitbat theme, scale up hirunningspace on > machines which can clearly afford the memory. > > This is a somewhat conservative version of the patch - more fine tuning may be > necessary. > > Idea from: Thread on hackers@ > Discussed with: alc > > Modified: > head/sys/kern/vfs_bio.c > > Modified: head/sys/kern/vfs_bio.c > ============================================================================== > --- head/sys/kern/vfs_bio.c Sun Jul 18 08:54:31 2010 (r210216) > +++ head/sys/kern/vfs_bio.c Sun Jul 18 10:15:33 2010 (r210217) > @@ -621,7 +621,9 @@ bufinit(void) > lobufspace = hibufspace - MAXBSIZE; > > lorunningspace = 512 * 1024; > - hirunningspace = 1024 * 1024; > + hirunningspace = lmin(roundup(hibufspace/64, MAXBSIZE), 16*1024*1024); > + if (hirunningspace < 1024 * 1024) > + hirunningspace = 1024 * 1024; Presumably you could use 'lmax(lmin(..., 16 * 1024 * 1024), 1024 * 1024))'? Also, the common style throughout the kernel is to provide spaces around operators like '/' and '*'. -- John Baldwin