From owner-cvs-all Tue Jul 17 9:50:51 2001 Delivered-To: cvs-all@freebsd.org Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40]) by hub.freebsd.org (Postfix) with ESMTP id 5399E37B403; Tue, 17 Jul 2001 09:50:45 -0700 (PDT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.acs.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.11.3/8.11.3) with ESMTP id f6HGofG36338; Tue, 17 Jul 2001 12:50:41 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: References: Date: Tue, 17 Jul 2001 12:50:39 -0400 To: Bruce Evans , John Baldwin From: Garance A Drosihn Subject: Re: cvs commit: src/usr.sbin/zic private.h scheck.c zic.c src/us Cc: Dima Dorfman , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, Garrett Wollman Content-Type: text/plain; charset="us-ascii" ; format="flowed" Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 5:47 PM +1000 7/17/01, Bruce Evans wrote: >On Mon, 16 Jul 2001, John Baldwin wrote: > > It's (realtively) small, so why not move it to contrib/ to make > > this more obvious? src/gnu is already somewhat off in its own > > namespace and is already treated as contrib stuff, however, how > > are committers supposed to know what "magical" parts of > > src/usr.s?bin/ are actually 3rd party? > >By reading the cvs history. We want a hard-and-fast rule that people should not casually change things in /usr/contrib. It's an easy rule to follow. If we're going to scatter "contrib" stuff all around the CVS tree, that makes the rule harder to follow. If we're not going to move zic into /usr/contrib, then maybe we could at least add a '/* NOTE */' to the README and the start of zic.c noting it's "contrib" status. I just looked at the CVS log for zic.c, for instance, and I must admit that nothing really jumped out at me saying "DON'T MODIFY THIS!". Yes, I see the bit about "merged changes from vendor branch", but I suspect that would not wave any red flag at me if I were just looking to modify this source. -- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message