Date: Sun, 23 Apr 2000 22:17:12 -0400 (EDT) From: Robert Muir <rmuir@looksharp.net> To: Brian Fundakowski Feldman <green@FreeBSD.ORG> Cc: hackers@FreeBSD.ORG Subject: Re: commit MAKE_SHELL? Message-ID: <Pine.BSF.4.21.0004232213530.18991-100000@turtle.looksharp.net> In-Reply-To: <Pine.BSF.4.21.0004231837560.46547-200000@green.dyndns.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I have been using it as well (with pdksh) for quite some time. I haven't compared speed, but it certainly hasn't broken anything. Robert Muir rmuir@looksharp.net On Sun, 23 Apr 2000, Brian Fundakowski Feldman wrote: > Some weeks ago, I made a small modification to make(1) so that it could > be built to use a different shell for its work. It already seemed to > have the idea at least partially thought out and in the code, so it was > a naturally easy thing to finish implementing. The code will remain > exactly the same unless you set the following (e.g. in make.conf): > > MAKE_SHELL=ksh > > Well, it's been sitting in my tree for a while now, and there have been > 0 problems with it. I use the ports and build worlds extensively, not > to mention having built everything which uses make(1) with this. The > pdksh is more than sufficiently Bourne (or shall I say compatible? It's > just a superset...) to support every single thing I've thrown at it. > Of course, it would be possible to use the real ksh with this patch, or > whatever ksh you want named "/bin/ksh". > > I certainly don't mind adding more shells to the ${MAKE_SHELL} logic, but > so far have only done ksh because using pdksh as the ${MAKE_SHELL} does, > for me, result in about 10% faster make world time, and speeds port > building enormously (though port building speed has gotten faster with > some reason optimizations made to the Mk/bsd.port*.mk files). > > I'd like to get public opinion on this change to see if many others will > find it useful. Note that the change also allows you to use "/bin/csh" > with MAKE_SHELL=csh, but you might not want to shoot yourself in the foot > like that :) Let me know if you find it useful to you; if people do find > it useful enough to have these make(1) speed increases, I'll commit it > to 5.0 and 4.0. It should also apply to 3.4, but I haven't tried it yet, > as my machines run -CURRENT. > > Let me know what kind of results you have :) I'm interested in results > with the real Korn shell, zsh, or bash, as well; I'll specifically add > those to the logic if people have good results there. > > Thanks for any feedback! > > -- > Brian Fundakowski Feldman \ FreeBSD: The Power to Serve! / > green@FreeBSD.org `------------------------------' > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0004232213530.18991-100000>