From owner-freebsd-current@FreeBSD.ORG Wed Oct 12 18:50:59 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C355516A421 for ; Wed, 12 Oct 2005 18:50:59 +0000 (GMT) (envelope-from caiquanqing@gmail.com) Received: from xproxy.gmail.com (xproxy.gmail.com [66.249.82.199]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0E51243D48 for ; Wed, 12 Oct 2005 18:50:57 +0000 (GMT) (envelope-from caiquanqing@gmail.com) Received: by xproxy.gmail.com with SMTP id t12so117402wxc for ; Wed, 12 Oct 2005 11:50:57 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=Vk10lzzcanNDb607JybyMjZK739D4MvyU4lRjAo3TwTbjACmVFC6WtAp/l5a17YbILnToYd8eUSpWs5Fn8Z5hWq0125G1n6+9UwHTIYqHcxczj9gl88s4B1VaWaeCmpD/8wR5BhT1VXklMlZfelc6mgAJgrzY+MF3astKowSxgo= Received: by 10.70.87.14 with SMTP id k14mr283476wxb; Wed, 12 Oct 2005 11:50:57 -0700 (PDT) Received: by 10.70.11.18 with HTTP; Wed, 12 Oct 2005 11:50:57 -0700 (PDT) Message-ID: <2b22951e0510121150o7be85033ic054cabed7e94e5e@mail.gmail.com> Date: Wed, 12 Oct 2005 11:50:57 -0700 From: "Cai, Quanqing" To: freebsd-current@freebsd.org, freebsd-drivers@freebsd.org, freebsd-firewire@freebsd.org, freebsd-net@freebsd.org In-Reply-To: <2b22951e0510121058u49cccf20kddd55352543c2304@mail.gmail.com> MIME-Version: 1.0 References: <2b22951e0510121058u49cccf20kddd55352543c2304@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: kiyohara@kk.iij4u.or.jp Subject: Re: Regarding kern/73852, please help to apply the patch thus we can close this bug. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2005 18:51:00 -0000 Forget to mention that my test machines, one is 7.0-CURRENT, another one is FreeBSD 6.0-RC1. So I think we can MFC to 6.x too. Cai, Quanqing On 10/12/05, Cai, Quanqing wrote: > > Hi guys, > > I noticed there is bug filed by KIYOHARA Takashi > with a patch, link is here: > http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dkern/73852, I tested if_fwip > with this patch, it works great for me. When we switch byte-order two tim= es > on i386, the byte-order will back to original. if you look at the files > src/lib/libc/i386/net/ntohl.S and src/lib/libc/i386/net/htonl.S, you will > find exact same code: > > movl 4(%esp),%eax > bswap %eax > ret > > This tells everything. > > So I hope somebody can apply the patch made by KIYOHARA Takashi and close > this bug. > > Thanks > Cai, Quanqing