From owner-freebsd-current@FreeBSD.ORG Sat Feb 17 16:22:33 2007 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 52E5616A52A for ; Sat, 17 Feb 2007 16:22:33 +0000 (UTC) (envelope-from rodrigc@crodrigues.org) Received: from alnrmhc13.comcast.net (alnrmhc13.comcast.net [204.127.225.93]) by mx1.freebsd.org (Postfix) with ESMTP id 262FF13C48E for ; Sat, 17 Feb 2007 16:22:33 +0000 (UTC) (envelope-from rodrigc@crodrigues.org) Received: from c-66-31-35-94.hsd1.ma.comcast.net ([66.31.35.94]) by comcast.net (alnrmhc13) with ESMTP id <20070217162228b13001g3rhe>; Sat, 17 Feb 2007 16:22:32 +0000 Received: from c-66-31-35-94.hsd1.ma.comcast.net (localhost.crodrigues.org [127.0.0.1]) by c-66-31-35-94.hsd1.ma.comcast.net (8.13.8/8.13.8) with ESMTP id l1HGMXGA028422; Sat, 17 Feb 2007 11:22:33 -0500 (EST) (envelope-from rodrigc@c-66-31-35-94.hsd1.ma.comcast.net) Received: (from rodrigc@localhost) by c-66-31-35-94.hsd1.ma.comcast.net (8.13.8/8.13.8/Submit) id l1HGMXgS028421; Sat, 17 Feb 2007 11:22:33 -0500 (EST) (envelope-from rodrigc) Date: Sat, 17 Feb 2007 11:22:33 -0500 From: Craig Rodrigues To: Olivier Houchard Message-ID: <20070217162233.GA28315@crodrigues.org> References: <790a9fff0702161738r154b5087m877c604092727e39@mail.gmail.com> <20070217021629.GA24579@ci0.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070217021629.GA24579@ci0.org> User-Agent: Mutt/1.4.2.1i Cc: Scot Hetzel , FreeBSD Current Subject: Re: mount_ntfs: /dev/ad0s1: No such file or directory X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Feb 2007 16:22:33 -0000 On Sat, Feb 17, 2007 at 03:16:29AM +0100, Olivier Houchard wrote: > That may be my fault. I think your recent patch to vfs_mount.c: cognet 2007-02-13 01:28:49 UTC FreeBSD src repository Modified files: sys/kern vfs_mount.c Log: Make vfs_getopts() set *error to ENOENT if the option wasn't found, so that consumers don't have to check for both error and the return value (some of them actually don't do it). MFC After: 1 week exposed some bugs in the NTFS mount code. Your patch to vfs_mount.c is a reasonable one, but it turns out to be an API change because it changes the behavior of vfs_getopts(). Did you audit all the file systems which use this function, and fix them to conform to the API change? -- Craig Rodrigues rodrigc@crodrigues.org