From owner-freebsd-hackers Mon Apr 15 7:45:47 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from clubfoot.cracktown.com (clubfoot.cracktown.com [208.226.218.141]) by hub.freebsd.org (Postfix) with ESMTP id 9292437B400 for ; Mon, 15 Apr 2002 07:45:36 -0700 (PDT) Received: from clubfoot.cracktown.com (localhost [127.0.0.1]) by clubfoot.cracktown.com (8.12.2/8.12.2) with ESMTP id g3FEm5aN026989; Mon, 15 Apr 2002 10:48:05 -0400 (EDT) (envelope-from joeo@cracktown.com) Received: from localhost (joeo@localhost) by clubfoot.cracktown.com (8.12.2/8.12.2/Submit) with ESMTP id g3FEm5ux026986; Mon, 15 Apr 2002 10:48:05 -0400 (EDT) X-Authentication-Warning: clubfoot.cracktown.com: joeo owned process doing -bs Date: Mon, 15 Apr 2002 10:48:05 -0400 (EDT) From: Joe O To: Frank Mayhar Cc: hackers@FreeBSD.ORG Subject: Re: Minor weirdness in pci/agp_amd.c. In-Reply-To: <20020415103041.A18331@freebsd.org> Message-ID: <20020415104315.N26711-100000@clubfoot.cracktown.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG This is probably the agp_amd.c driver from stable. It never got patched up with the irongate fix that went into current. Look ether into agp_amd.c in current or look through PR database on the the main freebsd website. On Mon, 15 Apr 2002, Coleman Kane wrote: > Is this in the -STABLE or -CURRENT version? I've been working on getting this > driver working, mostly from outside patches. > > -- > coleman > > On Sun, Apr 14, 2002 at 04:57:17PM -0700, Frank Mayhar wrote: > > I'm working on writing a driver for the ServerWorks AGP support from the > > Linux driver (sans documentation, SIGH :-(). I've been using the various > > other drivers as models, particularly the AMD driver, since it seems to be > > closest in many ways to the ServerWorks architecture. > > > > Anyway, I've run into a minor oddity in agp_amd_alloc_gatt(), in pci/agp_amd.c. > > At lines 120-121: > > gatt->ag_pdir = vtophys((vm_offset_t) gatt->ag_vdir); > > gatt->ag_pdir = vtophys(gatt->ag_virtual); > > > > Looks like one or the other is redundant? Probably the first, I would guess, > > if the code actually works as it is. > > -- > > Frank Mayhar frank@exit.com http://www.exit.com/ > > Exit Consulting http://www.gpsclock.com/ > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > > with "unsubscribe freebsd-hackers" in the body of the message > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-hackers" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message