Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 04 Dec 2018 05:58:26 +0000
From:      bugzilla-noreply@freebsd.org
To:        games@FreeBSD.org
Subject:   [Bug 233755] [NEW PORT] games/dxx-rebirth: Open source port of Descent and Descent 2
Message-ID:  <bug-233755-32059-HwamgxbCZL@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-233755-32059@https.bugs.freebsd.org/bugzilla/>
References:  <bug-233755-32059@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233755

--- Comment #3 from Tobias Kortkamp <tobik@freebsd.org> ---
Comment on attachment 199801
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D199801
shar

> For future reference, using svn diff or atleast diff is easier
> for committers

Meh.

sed 's/^X//' >games/dxx-rebirth/pkg-descr << '524fe70c0148e9d31768e7e4fa8bc=
0ee'
XAn open source re-implementation of Caesar III=20
X
XWWW: https://github.com/bvschaik/julius

Are you sure about pkg-descr? :p

XDISTNAME=3D      ${PORTNAME}-${PORTVERSION}-beta2-git
XWRKSRC=3D                ${WRKDIR}/${PORTNAME}-${PORTVERSION}-beta2

If you set DISTVERSION=3D0.60.0-beta2 as koobs suggested in addition to
EXTRACT_SUFX=3D-git.tar.gz you can drop these.

XUSES=3D          localbase:ldflags pkgconfig scons
XUSE_GL=3D                gl glu

This needs a USES=3Dgl

XMAKE_ARGS+=3D    ignore_unknown_variables=3D1

Why +=3D ?

XSUB_FILES=3D     pkg-message

I do not see any %%..%% in files/pkg-message.in so why not drop this and
move it to just pkg-message?

Xpost-install:
X               ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/d1x-rebirth \
X                       ${STAGEDIR}${PREFIX}/bin/d2x-rebirth

Please fix the indentation here.  First-level indentation in targets starts
with
one tab only, not two.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-233755-32059-HwamgxbCZL>