From owner-svn-ports-head@freebsd.org Tue Nov 3 05:02:47 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1ADE0A24F80; Tue, 3 Nov 2015 05:02:47 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) by mx1.freebsd.org (Postfix) with ESMTP id B5671128E; Tue, 3 Nov 2015 05:02:46 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id tTfGZzvv8T2votTfHZMZfc; Mon, 02 Nov 2015 21:57:48 -0700 X-Authority-Analysis: v=2.1 cv=NrEbCZpJ c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=BWvPGDcYAAAA:8 a=VxmjJ2MpAAAA:8 a=kj9zAlcOel0A:10 a=qtqOOiqGOCEA:10 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=XB5D3i7AIGpVe7hn2PIA:9 a=CjuIK1q_8ugA:10 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id A1E749CBE; Mon, 2 Nov 2015 20:57:46 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id tA34vkf5040066; Mon, 2 Nov 2015 20:57:46 -0800 (PST) (envelope-from Cy.Schubert@komquats.com) Message-Id: <201511030457.tA34vkf5040066@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.komquats.com/ To: marino@freebsd.org cc: Cy Schubert , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, hrs@freebsd.org Subject: Re: svn commit: r400565 - head/security/pam_krb5 In-Reply-To: Message from John Marino of "Mon, 02 Nov 2015 16:07:37 +0100." <56377C39.5000401@marino.st> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 02 Nov 2015 20:57:46 -0800 X-CMAE-Envelope: MS4wfMw+RHCBgkQzEYKQ2lbptXQ9Zza0frpwQNRa8kLV25TKOv6un8sVNBmyFcP98dakJ5eNiePWNrfh6GWS2qO6Cn1iP87cnlqVGPD2AdNKLpGDoGKP+57anoboEDzBwRcDUn/fS3fnl9iQAbxNvGe73Bnf/16PzlvPPsZfs3UJijjmB8xn2NdIFs/AdqL/nEUFWO+V/7hae9PWdbtoFyfP8+W9IMVxE1NgOSb98LzaXP0LJff+YK2JHu1YUP2TDvPACaTreQZmX7QQOA+ifOVGBXm9wh/XqIRYNqrX/iYzRA1nXm0GGPhC7+5QmT9GDxHlmQ== X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2015 05:02:47 -0000 In message <56377C39.5000401@marino.st>, John Marino writes: > > > > On 11/2/2015 4:01 PM, Cy Schubert wrote: > > In message <5637766F.6000404@marino.st>, John Marino writes: > >> On 11/2/2015 3:37 PM, Cy Schubert wrote: > >>> > >>> Looks like the tarball (port) never supported heimdal in ports in the fir > st > >> > >>> place. From ./configure: > >> > >> Why did it build before then? > >> > >> > >>> > >>> ac_fn_c_check_member "$LINENO" "krb5_creds" "session" > >>> "ac_cv_member_krb5_creds_s > >>> ession" " > >>> #if HAVE_KRB5_H > >>> # include > >>> #else > >>> # include > >>> #endif > >>> > >>> ./portable/krb5.h has the same code. > >>> > >>> Hiemdal in ports installs krb5.h ${LOCALBASE}/include/heimdal/krb5. I can > > >>> remove the option for now or (better) we can symlink > >>> ${LOCALBASE}/include/heimdal to ${LOCALBASE}/include/krb5 in the heimdal > >>> port. See attached patch. > >> > >> Heimdal ports is the only option that builds in dports, so removing it > >> means removing it from dports. > >> > >> krb.h is there (poudriere testport -i) : > >> > >> # ls /usr/local/include/heimdal/krb5.h > >> /usr/local/include/heimdal/krb5.h > >> > >> It should configure, right? > > > > Nope. ls /usr/local/include/krb5.h /usr/local/include/krb5/krb5.h > > > It is *already* using /usr/local/include/heimdal as it should be. It's > just not getting used in configure: > > > libtool: compile: cc -DHAVE_CONFIG_H -I. -I/usr/local/include/heimdal > -pipe -O2 -fno-strict-aliasing -MT portable/pam_vsyslog.lo -MD -MP -MF > portable/.deps/pam_vsyslog.Tpo -c portable/pam_vsyslog.c -fPIC -DPIC -o > portable/.libs/pam_vsyslog.o > libtool: compile: cc -DHAVE_CONFIG_H -I. -I/usr/local/include/heimdal > -pipe -O2 -fno-strict-aliasing -MT portable/reallocarray.lo -MD -MP -MF > portable/.deps/reallocarray.Tpo -c portable/reallocarray.c -fPIC -DPIC > -o portable/.libs/reallocarray.o > libtool: compile: cc -DHAVE_CONFIG_H -I. -I/usr/local/include/heimdal > -pipe -O2 -fno-strict-aliasing -MT portable/pam_syslog.lo -MD -MP -MF > portable/.deps/pam_syslog.Tpo -c portable/pam_syslog.c -fPIC -DPIC -o > portable/.libs/pam_syslog.o > libtool: compile: cc -DHAVE_CONFIG_H -I. -I/usr/local/include/heimdal > -pipe -O2 -fno-strict-aliasing -MT account.lo -MD -MP -MF > .deps/account.Tpo -c account.c -fPIC -DPIC -o .libs/account.o > In file included from account.c:21:0: > ./portable/krb5.h:48:24: fatal error: krb5/krb5.h: No such file or directory > compilation terminated. > > > > We don't have to settle for what it is. We can control the build flags. > > The bottom line is that a regression happened. If the current makefile > can't be fixed to operate as it was before, the change should be > reverted, right? Actually, it never worked in the first place. That is because the heimdal port puts its include files in ${LOCALBASE}/include/heimdal (take note of "heimdal" at the end of the path) and libraries in ${LOCALBASE}/lib/heimdal (same as above). Ldd ${LOCALBASE}/lib/security/pam_krb5.so makes that abundantly clear. Having said that, it's still no reason or excuse for it not to work. Tested in a virgin jail, it's working now, and committed. Sorry about the confusion. -- Cheers, Cy Schubert or FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.