From owner-p4-projects@FreeBSD.ORG Mon Jul 31 09:44:51 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 1C12A16A4E1; Mon, 31 Jul 2006 09:44:51 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D438E16A4DE for ; Mon, 31 Jul 2006 09:44:50 +0000 (UTC) (envelope-from piso@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 334E243D5D for ; Mon, 31 Jul 2006 09:44:46 +0000 (GMT) (envelope-from piso@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6V9ikeN002094 for ; Mon, 31 Jul 2006 09:44:46 GMT (envelope-from piso@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6V9ijPj002091 for perforce@freebsd.org; Mon, 31 Jul 2006 09:44:45 GMT (envelope-from piso@freebsd.org) Date: Mon, 31 Jul 2006 09:44:45 GMT Message-Id: <200607310944.k6V9ijPj002091@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to piso@freebsd.org using -f From: Paolo Pisati To: Perforce Change Reviews Cc: Subject: PERFORCE change 102841 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 09:44:51 -0000 http://perforce.freebsd.org/chv.cgi?CH=102841 Change 102841 by piso@piso_newluxor on 2006/07/31 09:43:49 Cosmetic Affected files ... .. //depot/projects/soc2005/libalias/sys/netinet/libalias/alias_db.c#3 edit .. //depot/projects/soc2005/libalias/sys/netinet/libalias/alias_dummy.c#6 edit Differences ... ==== //depot/projects/soc2005/libalias/sys/netinet/libalias/alias_db.c#3 (text+ko) ==== @@ -1041,7 +1041,7 @@ switch (link_type) { struct tcp_dat *aux_tcp; - case LINK_ICMP: + case LINK_ICMP: la->icmpLinkCount++; break; case LINK_UDP: @@ -2537,7 +2537,7 @@ #ifndef NO_FW_PUNCH UninitPunchFW(la); #endif - LIST_REMOVE(la, instancelist); + LIST_REMOVE(la, instancelist); free(la); } ==== //depot/projects/soc2005/libalias/sys/netinet/libalias/alias_dummy.c#6 (text+ko) ==== @@ -29,10 +29,9 @@ /* * Alias_dummy is just an empty skeleton used to demostrate how to write * a module for libalias, that will run unalterated in userland or in - * kernel land + * kernel land. */ -/* Includes */ #ifdef _KERNEL #include #include @@ -72,25 +71,25 @@ fingerprint(struct libalias *la, struct ip *pip, struct alias_data *ah) { /* - * check here all the data that will be used later, if any field - * is empy/NULL, return a -1 value + * Check here all the data that will be used later, if any field + * is empy/NULL, return a -1 value. */ if (ah->dport == NULL || ah->sport == NULL || ah->lnk == NULL || ah->maxpktsize == 0) return (-1); /* - * fingerprint the incoming packet, if it matches any conditions - * return an OK value + * Fingerprint the incoming packet, if it matches any conditions + * return an OK value. */ if (ntohs(*ah->dport) == 123 || ntohs(*ah->sport) == 456) - return (0); /* i know how to handle it... */ - return (-1); /* i don't know this packet... */ + return (0); /* I know how to handle it. */ + return (-1); /* I don't recognize this packet. */ } /* * Wrap in this general purpose function, the real function used to alias the - * packets + * packets. */ static int @@ -154,6 +153,6 @@ static void AliasHandleDummy(struct libalias *la, struct ip *ip, struct alias_data *ah) { - ; /* dummy */ + ; /* Dummy. */ }