Date: Tue, 12 Oct 2004 15:24:27 -0700 From: Alfred Perlstein <alfred@freebsd.org> To: Don Lewis <truckman@FreeBSD.org> Cc: jhb@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_subr.c Message-ID: <20041012222427.GU38364@elvis.mu.org> In-Reply-To: <200410122220.i9CMKk5D073276@gw.catspoiler.org> References: <200410122217.i9CMGuoY073261@gw.catspoiler.org> <200410122220.i9CMKk5D073276@gw.catspoiler.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* Don Lewis <truckman@FreeBSD.org> [041012 15:21] wrote: > On 12 Oct, Don Lewis wrote: > > On 12 Oct, Alfred Perlstein wrote: > >> I like this, my only concern is that there may be places that > >> call this with locks held but with the kernel/user buffer wired > >> so that it can't fault. > >> > >> Are you sure this isn't the case? (specifically for some sysctls) > > > > There are a number of sysctl handlers where I added code to wire the > > buffer so that there was no danger of sleeping while a mutex is held. > > Allocating a kernel buffer and doing an extra copy would be ugly. > > Oh, nevermind. The sysctl handlers use copyout(), not uiomove(). Doing > Adding WITNESS_WARN() to uiomove() is probably a good thing. Oy. :) Ok. -- - Alfred Perlstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041012222427.GU38364>