From owner-svn-src-head@FreeBSD.ORG  Wed Sep  1 01:24:02 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CA7FA10656BE;
	Wed,  1 Sep 2010 01:24:02 +0000 (UTC)
	(envelope-from davidxu@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id B9A788FC0C;
	Wed,  1 Sep 2010 01:24:02 +0000 (UTC)
Received: from [127.0.0.1] (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o811O0DX061383;
	Wed, 1 Sep 2010 01:24:01 GMT (envelope-from davidxu@freebsd.org)
Message-ID: <4C7E1BB1.3080209@freebsd.org>
Date: Wed, 01 Sep 2010 09:24:01 +0000
From: David Xu <davidxu@freebsd.org>
User-Agent: Thunderbird 2.0.0.24 (X11/20100630)
MIME-Version: 1.0
To: Jilles Tjoelker <jilles@stack.nl>
References: <201008310715.o7V7FoSI021421@svn.freebsd.org>
	<20100831181631.GA31653@stack.nl>
In-Reply-To: <20100831181631.GA31653@stack.nl>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r212047 - head/sys/kern
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Sep 2010 01:24:03 -0000

Jilles Tjoelker wrote:
> On Tue, Aug 31, 2010 at 07:15:50AM +0000, David Xu wrote:
>> Author: davidxu
>> Date: Tue Aug 31 07:15:50 2010
>> New Revision: 212047
>> URL: http://svn.freebsd.org/changeset/base/212047
> 
>> Log:
>>   If a process is being debugged, skips job control caused by SIGSTOP/SIGCONT
>>   signals, because it is managed by debugger, however a normal signal sent to
>>   a interruptibly sleeping thread wakes up the thread so it will handle the
>>   signal when the process leaves the stopped state.
> 
>>   PR:	150138
>>   MFC after:	1 week
> 
>> Modified:
>>   head/sys/kern/kern_sig.c
> 
>> Modified: head/sys/kern/kern_sig.c
>> ==============================================================================
>> --- head/sys/kern/kern_sig.c	Tue Aug 31 06:22:03 2010	(r212046)
>> +++ head/sys/kern/kern_sig.c	Tue Aug 31 07:15:50 2010	(r212047)
>>  		if (sig == SIGKILL) {
>> +			if (p->p_flag & P_TRACED)
>> +				goto out;
>>  			/*
>>  			 * SIGKILL sets process running.
>>  			 * It will die elsewhere.
> 
> Hmm, shouldn't SIGKILL kill right away regardless of debuggers?
> 

Hmm^2, it is a history behavior.