Date: Wed, 12 Sep 2001 23:59:21 -0700 From: Julian Elischer <julian@elischer.org> To: Warner Losh <imp@harmony.village.org> Cc: current@FreeBSD.ORG, FreeBSD98-testers@jp.freebsd.org Subject: Re: KSE usage, and one forgotten item (PC98) Message-ID: <3BA05949.1CCB2D82@elischer.org> References: <200109130128.f8D1Sdt63787@harmony.village.org> <Pine.BSF.4.21.0109121737020.59165-100000@InterJet.elischer.org> <200109130314.f8D3E4t94541@harmony.village.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Warner Losh wrote: > > # please excuse this message in English to the traditionally Japanese list. > # Julians changes broke pc98 builds with his KSE commits. > > In message <200109130128.f8D1Sdt63787@harmony.village.org> Warner Losh writes: > : Actaully, the issues are that machdep and friends weren't updated. > > Please review http://people.freebsd.org/~imp/pc98.diff > > and pay special attention to what I did to fd.c. I wasn't sure. The > rest were mechanical no-brainers. > > I booted this on my PC-9821Nr, but had no console compiled with > kernel. A kernel from before the change also has this problem, so I > don't know what to think. > > Warner All looks good.. obviously the logic of what was going on was easy enough to pick up :-) the only bit I didn't see so easily was: static int -fdformat(dev, finfo, p) +fdformat(dev, finfo, td) dev_t dev; struct fd_formb *finfo; - struct proc *p; + struct thread *td; { + struct proc *p = td->td_proc; fdu_t fdu; fd_p fd; @@ -2860,7 +2861,7 @@ /* * keep the process from being swapped */ - PHOLD(p); + PROC_LOCK(p); bzero((void *)bp, sizeof(*bp)); bp->bio_cmd = BIO_FORMAT; @@ -2898,7 +2899,7 @@ /* * allow the process to be swapped */ - PRELE(p); + PROC_UNLOCK(p); free(bp, M_TEMP); return rv; } the replacement of PHOLD with PROC_LOCK().. I'm not sure of what this actualy means.. the rest is as you say...mechanical.. -- +------------------------------------+ ______ _ __ | __--_|\ Julian Elischer | \ U \/ / hard at work in | / \ julian@elischer.org +------>x USA \ a very strange | ( OZ ) \___ ___ | country ! +- X_.---._/ presently in San Francisco \_/ \\ v To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3BA05949.1CCB2D82>