Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 16 Apr 2002 09:15:19 +1000 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        "David E. O'Brien" <obrien@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, <cvs-all@FreeBSD.org>
Subject:   Re: cvs commit: src/usr.bin/make str.c
Message-ID:  <20020416090400.G6024-100000@gamplex.bde.org>
In-Reply-To: <200204130949.g3D9nYE31181@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 13 Apr 2002, David E. O'Brien wrote:

> obrien      2002/04/13 02:49:34 PDT
>
>   Modified files:
>     usr.bin/make         str.c
>   Log:
>   Constify str_concat()
>
>   Submitted by:   jmallett
>
>   Revision  Changes    Path
>   1.15      +4 -4      src/usr.bin/make/str.c

This is another example of wrong WARNSification.  str_concat() doesn't
actually take const char * args any more than free() takes a const void *
arg, since it sometimes frees its args.

This also breaks bootstrapping from RELENG_4 by using the __DECONST()
mistake.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020416090400.G6024-100000>