From owner-freebsd-bugs Wed Jul 11 2:50: 9 2001 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id A80F337B403 for ; Wed, 11 Jul 2001 02:50:00 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.3/8.11.3) id f6B9o0j47442; Wed, 11 Jul 2001 02:50:00 -0700 (PDT) (envelope-from gnats) Received: from krusty.e-technik.uni-dortmund.de (krusty.E-Technik.Uni-Dortmund.DE [129.217.163.1]) by hub.freebsd.org (Postfix) with ESMTP id C28F837B405 for ; Wed, 11 Jul 2001 02:49:21 -0700 (PDT) (envelope-from matthias.andree@web.de) Received: from emma1.emma.line.org (krusty.dt.e-technik.uni-dortmund.de [129.217.163.1]) by krusty.e-technik.uni-dortmund.de (Postfix) with ESMTP id 5F139A3826 for ; Wed, 11 Jul 2001 11:49:20 +0200 (CEST) Received: from freebsd.emma.line.org (freebsd.emma.line.org [192.168.0.4]) by emma1.emma.line.org (Postfix) with ESMTP id 88736A2001 for ; Wed, 11 Jul 2001 11:49:19 +0200 (CEST) Received: by freebsd.emma.line.org (Postfix, from userid 500) id B4B462D310; Wed, 11 Jul 2001 11:49:17 +0200 (CEST) Message-Id: <20010711094917.B4B462D310@freebsd.emma.line.org> Date: Wed, 11 Jul 2001 11:49:17 +0200 (CEST) From: matthias.andree@web.de Reply-To: matthias.andree@web.de To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.113 Subject: misc/28890: update to mergesort/merge.c: match i and size types. Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 28890 >Category: misc >Synopsis: merge.c compares int i against size_t size >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Jul 11 02:50:00 PDT 2001 >Closed-Date: >Last-Modified: >Originator: Matthias Andree >Release: FreeBSD 4.3-RELEASE i386 >Organization: >Environment: System: FreeBSD freebsd.emma.line.org 4.3-RELEASE FreeBSD 4.3-RELEASE #5: Tue Jul 10 17:12:16 CEST 2001 root@freebsd.emma.line.org:/usr/src/sys/compile/M2A2 i386 >Description: /usr/src/lib/libc/stdlib/merge.c compares i against size at lines 169 and 182. i is of type int and size of type size_t, their signedness doesn't match. >How-To-Repeat: run merge.c through gcc with -W -Wall >Fix: Apply this patch: *** merge.c.old Wed Jul 11 11:47:20 2001 --- merge.c Wed Jul 11 11:47:43 2001 *************** *** 101,107 **** register size_t size; int (*cmp) __P((const void *, const void *)); { ! register int i, sense; int big, iflag; register u_char *f1, *f2, *t, *b, *tp2, *q, *l1, *l2; u_char *list2, *list1, *p2, *p, *last, **p1; --- 101,108 ---- register size_t size; int (*cmp) __P((const void *, const void *)); { ! register size_t i; ! register int sense; int big, iflag; register u_char *f1, *f2, *t, *b, *tp2, *q, *l1, *l2; u_char *list2, *list1, *p2, *p, *last, **p1; >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message