From owner-svn-src-all@freebsd.org Thu Sep 6 15:26:36 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9B7CCFFE496 for ; Thu, 6 Sep 2018 15:26:36 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1168C7BE39 for ; Thu, 6 Sep 2018 15:26:36 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-wr1-x441.google.com with SMTP id k5-v6so11842201wre.10 for ; Thu, 06 Sep 2018 08:26:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=P9hFrAmsfTsiALyZGSEcg1DHaSgf383lbVH2v2Qp6xk=; b=gc9fRk7ne7x9em/8N8H59sDvUNWANITjKnAOw3j52pn/NDy752C6cqmSSBCHjYQWKn TYFmpUozmgfygJm9ynaWQCIX+oRlLwakO9A2apw2W8eYiw3ESnjPlk5sZAFH7cbLIHZ9 TW4VPHt7egDDYurTTontCfUBqoB7+woLXsdvgEf5eNm951lp+ArheyerlSpkNe8czy+C 4HBBgBFt9ZAz+ClNh2WTpae6ZYm32RtZNwZi8FXSUjIEJeaVVbdR/AJhlBON0IkScNpr ofcQwqoMVP7Zou426gv3qZLPBJWWMs2vprY6hGnrHdIdxC6Y/Q+tZ/QFlmj0smVhTB6B SFaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=P9hFrAmsfTsiALyZGSEcg1DHaSgf383lbVH2v2Qp6xk=; b=qEwTisbZYZRnRLWGGkxY1t1RUkm9KrncHrrRxjWyxbUw+3FIJHdBFsMrzXAfFrAsdN p1HoOoqS+DUyXQs2v2m3fq2B5fCcX/USLk1afncY9J4DmIV+BDZeInXK0MP63ifnBmPd mOIG5+Ydw85xV9BprP2YX+E1tMmfXaeKQ/dtfr/etDciVIfBhgTxZuxo8XiW1aI+qKVm LBS7MnbAHVwELfuO3Fi8xBCvUtb3UW9Q5Jl0dzmYxOM+H4NKADNV2e1Ufn25m3bOTePy oKmfOIyHKPSUgNhEfcxfpHQ4nsR4pPOaAjWuYutFYEgtDAMqE3PkT6338954qswZWrd3 b1Dw== X-Gm-Message-State: APzg51DJIE+P+cQTYOJTcODzWgp7J/uAodTaTlDgM0fDmsaQ9sR6OaZR BB3BVmn0GR+lz9V6R9U4EOHfTg== X-Google-Smtp-Source: ANB0VdYpsJ7bEjsm9p0PnORPV+q+ReM9AGyCVtOc69aO6mLMBnp0flpJFNhOFgpR2bITWb8VNjxr7A== X-Received: by 2002:adf:9d81:: with SMTP id p1-v6mr2707299wre.12.1536247594855; Thu, 06 Sep 2018 08:26:34 -0700 (PDT) Received: from mutt-hbsd (exit1.ipredator.se. [197.231.221.211]) by smtp.gmail.com with ESMTPSA id d10-v6sm9448610wrv.70.2018.09.06.08.26.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Sep 2018 08:26:34 -0700 (PDT) Date: Thu, 6 Sep 2018 11:25:33 -0400 From: Shawn Webb To: John Baldwin Cc: Alexander Motin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r338494 - head/sys/cam/ctl Message-ID: <20180906152533.ygsqei2jgod42ydt@mutt-hbsd> References: <201809061403.w86E3AUm097915@repo.freebsd.org> <20180906145421.7mejwhcfezwtsk4k@mutt-hbsd> <51c27534-8cc2-cd30-dd53-77fd7ad5bdf7@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="snqdvlofjpj57woe" Content-Disposition: inline In-Reply-To: <51c27534-8cc2-cd30-dd53-77fd7ad5bdf7@FreeBSD.org> X-Operating-System: FreeBSD mutt-hbsd 12.0-ALPHA4 FreeBSD 12.0-ALPHA4 X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0x6A84658F52456EEE User-Agent: NeoMutt/20180622 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Sep 2018 15:26:36 -0000 --snqdvlofjpj57woe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 06, 2018 at 08:24:32AM -0700, John Baldwin wrote: > On 9/6/18 7:54 AM, Shawn Webb wrote: > > On Thu, Sep 06, 2018 at 02:03:10PM +0000, Alexander Motin wrote: > >> Author: mav > >> Date: Thu Sep 6 14:03:10 2018 > >> New Revision: 338494 > >> URL: https://svnweb.freebsd.org/changeset/base/338494 > >> > >> Log: > >> Add missing copyin() to access LUN and port ioctl arguments. > >> =20 > >> Somehow this was working even after PTI in, at least on amd64, and g= ot > >> broken by something only very recently. > >=20 > > Is anyone investigating why the direct access still worked? >=20 > PTI doesn't disable kernel access to user pages, it only disables > translation of kernel virtual addresses while in user mode. The thing th= at > catches this type of access is SMAP (which was only recently enabled on > x86). Whoops. Blonde moment. I blame the lack of caffeine in my body when I wrote the email. Too many acronyms to keep track of when tired. ;) Thanks for the clarification. --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: lattera@is.a.hacker.sx GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --snqdvlofjpj57woe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAluRRugACgkQaoRlj1JF bu7ULA/+I1hk2FVR+dUlyVvrzC27vUO24PZAX/Fh4Iih/whj+PEAkJoPPwBviPGR QVt8Ie+NThM0Su3mcR8RxXopzoB3Bac8g+qo2AeIilfeVDUjOBFuqaSwVYeLbk9t 3Kg0+dxZSSnJ7B/odkMv6WiodDdK8lVpKtgQrrkrXrRLHlbpVJHSdPttrcJbD41G rf7uW9L45k6QK3Q3+Rqk9efD3ifeGSsAPvTe7I3HTROoDc9Oyi9lKQm28C+yfxTN elQG/lu1RUksbIUhZ7x7sNYFnzUhY3VOScZ4tno6rui7RY411DvpB+PXATe2WgRP VdO6dvH6FEqymxF3QX32HrgSZjJdEU1tTyL8D8PpWdliPVcILZg77fxhV/mHLTRz rHBf6vk78MW1znanJDLAPHyN1xrxB9HX/TwnQOLWLIJGHhKkxYZqL8/VP5ZoVpsb kqjLwzBxPo5ibYAGDYlwdebVo4y5P6czmaZBHFqOKKRglrQWiUH8JEkEzaVWldIx AEfoGZzxHyXeur4yqTiwwmVvIxujbwM7vJdpzuBmtkHfoULymy1r+Uxdlvksf4Mw X7kRrfH4C9yBXe8AASfLWRC8HtkTmlfKekNt/vnXjoiGJ/GaMhEetlMyl0UFQSpv PT3vAqvPMlt2RxnuWOutYGslPUssI9fVm/3OLdMo37aHe5wR7FE= =Jfjr -----END PGP SIGNATURE----- --snqdvlofjpj57woe--