From owner-cvs-all@FreeBSD.ORG  Tue Apr 22 00:02:31 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B57D4106566C;
	Tue, 22 Apr 2008 00:02:31 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 7E1228FC0C;
	Tue, 22 Apr 2008 00:02:31 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id m3M00eQW036591;
	Mon, 21 Apr 2008 18:00:42 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Mon, 21 Apr 2008 18:01:44 -0600 (MDT)
Message-Id: <20080421.180144.-1676909581.imp@bsdimp.com>
To: phk@phk.freebsd.dk
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <99531.1208814953@critter.freebsd.dk>
References: <20080421213724.GL82555@funkthat.com>
	<99531.1208814953@critter.freebsd.dk>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, jmg@funkthat.com, bz@FreeBSD.org, cvs-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/ata ata-all.c 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Apr 2008 00:02:31 -0000

In message: <99531.1208814953@critter.freebsd.dk>
            "Poul-Henning Kamp" <phk@phk.freebsd.dk> writes:
: In message <20080421213724.GL82555@funkthat.com>, John-Mark Gurney writes:
: 
: >Any one object to changing:
: >.Nm devclass_get_maxunit
: >.Nd find the maximum unit number in the class
: >
: >to:
: >.Nm devclass_get_maxunit
: >.Nd find the next free unit number in the class
: 
: Those are very different semantics, the name should change as well
: then.

The change isn't in semantics of the function call.  It is just the
description of what it does.

Agreed that it is a bad interface name..

Warner