Date: Sat, 17 Feb 2007 17:49:04 +0100 From: Olivier Houchard <mlfbsd@cognet.ci0.org> To: Craig Rodrigues <rodrigc@crodrigues.org> Cc: Scot Hetzel <swhetzel@gmail.com>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: mount_ntfs: /dev/ad0s1: No such file or directory Message-ID: <20070217164904.GA31437@ci0.org> In-Reply-To: <20070217162233.GA28315@crodrigues.org> References: <790a9fff0702161738r154b5087m877c604092727e39@mail.gmail.com> <20070217021629.GA24579@ci0.org> <20070217162233.GA28315@crodrigues.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Feb 17, 2007 at 11:22:33AM -0500, Craig Rodrigues wrote: > On Sat, Feb 17, 2007 at 03:16:29AM +0100, Olivier Houchard wrote: > > That may be my fault. > > I think your recent patch to vfs_mount.c: > > cognet 2007-02-13 01:28:49 UTC > > FreeBSD src repository > > Modified files: > sys/kern vfs_mount.c > Log: > Make vfs_getopts() set *error to ENOENT if the option wasn't found, so that > consumers don't have to check for both error and the return value (some of > them actually don't do it). > > MFC After: 1 week > > > > exposed some bugs in the NTFS mount code. Your patch to > vfs_mount.c is a reasonable one, but it turns out to be an API change > because it changes the behavior of vfs_getopts(). Did you > audit all the file systems which use this function, and fix them > to conform to the API change? > Hi Craig, Apparently not enough ;-) I'm in discussion with Bruce Evans about this, he brought up valid concerns about this change, maybe I'll revert it and check all consumers of vfs_getopts to make sure they check the return value instead. Cheers, Olivier
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070217164904.GA31437>