From owner-freebsd-current@FreeBSD.ORG  Sat Feb 17 16:30:46 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id DC4D316A401
	for <freebsd-current@freebsd.org>; Sat, 17 Feb 2007 16:30:46 +0000 (UTC)
	(envelope-from mlfbsd@dong.ci0.org)
Received: from dong.ci0.org (cognet.ci0.org [80.65.224.102])
	by mx1.freebsd.org (Postfix) with ESMTP id 4651B13C474
	for <freebsd-current@freebsd.org>; Sat, 17 Feb 2007 16:30:45 +0000 (UTC)
	(envelope-from mlfbsd@dong.ci0.org)
Received: from dong.ci0.org (localhost.ci0.org [127.0.0.1])
	by dong.ci0.org (8.13.7/8.13.4) with ESMTP id l1HGn4Rh031470;
	Sat, 17 Feb 2007 17:49:04 +0100 (CET)
	(envelope-from mlfbsd@dong.ci0.org)
Received: (from mlfbsd@localhost)
	by dong.ci0.org (8.13.8/8.13.8/Submit) id l1HGn4bY031469;
	Sat, 17 Feb 2007 17:49:04 +0100 (CET) (envelope-from mlfbsd)
Date: Sat, 17 Feb 2007 17:49:04 +0100
From: Olivier Houchard <mlfbsd@cognet.ci0.org>
To: Craig Rodrigues <rodrigc@crodrigues.org>
Message-ID: <20070217164904.GA31437@ci0.org>
References: <790a9fff0702161738r154b5087m877c604092727e39@mail.gmail.com>
	<20070217021629.GA24579@ci0.org>
	<20070217162233.GA28315@crodrigues.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070217162233.GA28315@crodrigues.org>
User-Agent: Mutt/1.4.1i
Cc: Scot Hetzel <swhetzel@gmail.com>,
	FreeBSD Current <freebsd-current@freebsd.org>
Subject: Re: mount_ntfs: /dev/ad0s1: No such file or directory
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 17 Feb 2007 16:30:46 -0000

On Sat, Feb 17, 2007 at 11:22:33AM -0500, Craig Rodrigues wrote:
> On Sat, Feb 17, 2007 at 03:16:29AM +0100, Olivier Houchard wrote:
> > That may be my fault.
> 
> I think your recent patch to vfs_mount.c:
> 
> cognet      2007-02-13 01:28:49 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/kern             vfs_mount.c
>   Log:
>   Make vfs_getopts() set *error to ENOENT if the option wasn't found, so that
>   consumers don't have to check for both error and the return value (some of
>   them actually don't do it).
> 
>   MFC After:      1 week
> 
> 
> 
> exposed some bugs in the NTFS mount code.  Your patch to
> vfs_mount.c is a reasonable one, but it turns out to be an API change
> because it changes the behavior of vfs_getopts().  Did you
> audit all the file systems which use this function, and fix them
> to conform to the API change?
> 

Hi Craig,

Apparently not enough ;-)
I'm in discussion with Bruce Evans about this, he brought up valid concerns
about this change, maybe I'll revert it and check all consumers of vfs_getopts
to make sure they check the return value instead.

Cheers,

Olivier