From owner-p4-projects@FreeBSD.ORG  Fri Aug  8 11:29:51 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 0CE3637B404; Fri,  8 Aug 2003 11:29:51 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9827C37B408
	for <perforce@freebsd.org>; Fri,  8 Aug 2003 11:29:50 -0700 (PDT)
Received: from mail.speakeasy.net (mail12.speakeasy.net [216.254.0.212])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8E8CC43F3F
	for <perforce@freebsd.org>; Fri,  8 Aug 2003 11:29:49 -0700 (PDT)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 9892 invoked from network); 8 Aug 2003 18:29:48 -0000
Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63])
	(envelope-sender <jhb@FreeBSD.org>)encrypted SMTP
	for <perforce@freebsd.org>; 8 Aug 2003 18:29:48 -0000
Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1])
	by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h78ITl9s037438;
	Fri, 8 Aug 2003 14:29:47 -0400 (EDT)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.20030808142831.jhb@FreeBSD.org>
X-Mailer: XFMail 1.5.4 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <200308072230.h77MUtBU024118@repoman.freebsd.org>
Date: Fri, 08 Aug 2003 14:28:31 -0400 (EDT)
From: John Baldwin <jhb@FreeBSD.org>
To: Sam Leffler <sam@FreeBSD.org>
cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: RE: PERFORCE change 35749 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Aug 2003 18:29:52 -0000


On 07-Aug-2003 Sam Leffler wrote:
> http://perforce.freebsd.org/chv.cgi?CH=35749
> 
> Change 35749 by sam@sam_ebb on 2003/08/07 15:29:55
> 
>       o must unlock before destroying mutex
>       o must lock rt_gwroute before freeing when cleaning up on error

It's ok to own a mutex when you destroy it.  It's actually fairly desirable in
fact since it is a rather foolproof way of making sure someone eles doesn't own
it.  Of course, they could still be blocked on it.. :-/

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/