From owner-freebsd-net@FreeBSD.ORG  Mon Jun  8 22:45:44 2015
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 3616C373
 for <freebsd-net@freebsd.org>; Mon,  8 Jun 2015 22:45:44 +0000 (UTC)
 (envelope-from rmacklem@uoguelph.ca)
Received: from esa-jnhn.mail.uoguelph.ca (esa-jnhn.mail.uoguelph.ca
 [131.104.91.44]) by mx1.freebsd.org (Postfix) with ESMTP id 01C701BD7
 for <freebsd-net@freebsd.org>; Mon,  8 Jun 2015 22:45:43 +0000 (UTC)
 (envelope-from rmacklem@uoguelph.ca)
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A2DUBAAJGnZV/95baINchEiDGMM4gW4RAQEBAQEBAYEKhEyBCwINGQJfiECaK49fpAABCgEBAR6BIY50gyOBRQWgB4N6iA6GTYNZJIIJHIFuIoF3gQEBAQE
X-IronPort-AV: E=Sophos;i="5.13,576,1427774400"; d="scan'208";a="214991352"
Received: from muskoka.cs.uoguelph.ca (HELO zcs3.mail.uoguelph.ca)
 ([131.104.91.222])
 by esa-jnhn.mail.uoguelph.ca with ESMTP; 08 Jun 2015 18:45:38 -0400
Received: from zcs3.mail.uoguelph.ca (localhost.localdomain [127.0.0.1])
 by zcs3.mail.uoguelph.ca (Postfix) with ESMTP id 06A01B3FD0
 for <freebsd-net@freebsd.org>; Mon,  8 Jun 2015 18:45:37 -0400 (EDT)
Date: Mon, 8 Jun 2015 18:45:37 -0400 (EDT)
From: Rick Macklem <rmacklem@uoguelph.ca>
To: freebsd-net <freebsd-net@freebsd.org>
Message-ID: <597381612.53959816.1433803537015.JavaMail.root@uoguelph.ca>
Subject: setting if_hw_tsomax{segcount, segsize} in net drivers
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Originating-IP: [172.17.95.11]
X-Mailer: Zimbra 7.2.6_GA_2926 (ZimbraWebClient - FF3.0 (Win)/7.2.6_GA_2926)
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Jun 2015 22:45:44 -0000

Hi,

I just looked at stable/10 and found the following 4 drivers have
set the if_hw_tsomax, if_hw_tsomaxsegcount and if_hw_tsomaxsegsize
fields:

./xen/netfront/netfront.c
./cxgbe/t4_main.c
./oce/oce_if.c
./vmware/vmxnet3/if_vmx.c

If you are the author/maintainer for a network device driver that does
TSO and is not on the above list...please, please fill in the above
fields before the call to ether_ifattach(), so that TSO will hopefully
work correctly with NFS/iSCSI. (I said "hopefully" because there might
be other bugs related to TSO in your driver that I wouldn't know about.)

Maybe someone could mention this at BSDCan too?

Thanks in advance for doing this, rick
ps: I would be really nice to get this done for 10.2 imho.