Date: Tue, 10 Sep 2013 14:24:39 -0400 From: John Baldwin <jhb@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r255426 - in head: lib/libc/sys sys/compat/freebsd32 sys/compat/linux sys/compat/svr4 sys/dev/drm2/i915 sys/i386/ibcs2 sys/i386/linux sys/ia64/ia32 sys/kern sys/sparc64/sparc64 sys/sys ... Message-ID: <201309101424.39322.jhb@freebsd.org> In-Reply-To: <20130910092323.GA58955@FreeBSD.org> References: <201309091812.r89IC0YH015840@svn.freebsd.org> <20130910092323.GA58955@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, September 10, 2013 5:23:23 am Alexey Dokuchaev wrote: > On Mon, Sep 09, 2013 at 06:12:00PM +0000, John Baldwin wrote: > > New Revision: 255426 > > URL: http://svnweb.freebsd.org/changeset/base/255426 > > > > Log: > > [...] > > To facilitate this, add a new parameter to vm_map_find() that specifies an > > optional maximum virtual address. While here, fix several callers of > > vm_map_find() to use a VMFS_* constant for the findspace argument instead > > of TRUE and FALSE. > > This commit breaks NVidia driver port, and (again) there was no corresponding > __FreeBSD_version bump. My bad, I completely missed the version bump. Userland consumers can use #ifdef MAP_32BIT which is why I didn't add one. > This is another recent incident with -CURRENT silently changing KPIs that are > publicly used. To be fair, these are fairly internal KPIs unlike, say, the cdevsw interface that is widely used in many drivers. You can count all of the internal and external users of this function on two hands. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201309101424.39322.jhb>