Date: Mon, 2 Sep 2013 01:41:08 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Mark Felder <feld@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r325891 - in head/dns/rbldnsd: . files Message-ID: <20130902014108.GE43972@FreeBSD.org> In-Reply-To: <201309011728.r81HSx4Z057688@svn.freebsd.org> References: <201309011728.r81HSx4Z057688@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Sep 01, 2013 at 05:28:59PM +0000, Mark Felder wrote: > New Revision: 325891 > URL: http://svnweb.freebsd.org/changeset/ports/325891 > > @@ -37,6 +23,8 @@ GROUPS= ${USERS} > PKGMESSAGE= ${WRKDIR}/pkg-message > SUB_FILES= pkg-message > > +.include <bsd.port.pre.mk> > + Any reason not to use <bsd.port.options.mk> instead? > do-install: > @if [ ! -d ${ROOTDIR} ]; then \ > ${MKDIR} ${ROOTDIR}; \ > @@ -47,7 +35,7 @@ do-install: > ${FILESDIR}/example ${PREFIX}/etc/rbldnsd/ > @${INSTALL_PROGRAM} ${WRKSRC}/rbldnsd ${PREFIX}/sbin/ > @${INSTALL_MAN} ${WRKSRC}/rbldnsd.8 ${PREFIX}/man/man8/ The whole do-install recipe is badly indented (extra tabstop); destination paths carry bogus slashes at EOL, manpages should be installed relative to MAN[n]PREFIX (where optional n is section number). > -.if !defined(NOPORTDOCS) > +.if ${PORT_OPTIONS:MDOCS} > @${MKDIR} ${DOCSDIR}/ > @${INSTALL_DATA} ${WRKSRC}/CHANGES-0.81 ${DOCSDIR} > @${INSTALL_DATA} ${WRKSRC}/TODO ${DOCSDIR} > @@ -57,7 +45,6 @@ do-install: > @${INSTALL_DATA} ${WRKSRC}/debian/rbldnsd.default ${DOCSDIR} > @${INSTALL_DATA} ${WRKSRC}/debian/rbldnsd.init ${DOCSDIR} > @${INSTALL_DATA} ${WRKSRC}/rbldnsd.spec ${DOCSDIR} > - @${INSTALL_DATA} ${DISTDIR}/rbldnsd.html ${DOCSDIR} We do not mute installation commands (muting MKDIR is fine). Silent build log does help to debug any potential problems. > .endif > > -.include <bsd.port.mk> > +.include <bsd.port.post.mk> Using <bsd.port.options.mk> above would have allow you to avoid changing this line. > --- head/dns/rbldnsd/pkg-plist Sun Sep 1 17:28:00 2013 (r325890) > +++ head/dns/rbldnsd/pkg-plist Sun Sep 1 17:28:59 2013 (r325891) > @@ -8,6 +8,5 @@ etc/rbldnsd/example > %%PORTDOCS%%%%DOCSDIR%%/rbldnsd.default > %%PORTDOCS%%%%DOCSDIR%%/rbldnsd.init > %%PORTDOCS%%%%DOCSDIR%%/rbldnsd.spec > -%%PORTDOCS%%%%DOCSDIR%%/rbldnsd.html > %%PORTDOCS%%@dirrm %%DOCSDIR%% > @dirrmtry etc/rbldnsd/ Superfluous slash at EOL. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130902014108.GE43972>