From owner-freebsd-ports-bugs@FreeBSD.ORG  Mon Jan 15 03:10:13 2007
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
X-Original-To: freebsd-ports-bugs@hub.freebsd.org
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 6CBBF16A407
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Mon, 15 Jan 2007 03:10:13 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40])
	by mx1.freebsd.org (Postfix) with ESMTP id 25E1D13C465
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Mon, 15 Jan 2007 03:10:13 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l0F3ACNt092596
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Mon, 15 Jan 2007 03:10:13 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l0F3ACb8092594;
	Mon, 15 Jan 2007 03:10:12 GMT (envelope-from gnats)
Resent-Date: Mon, 15 Jan 2007 03:10:12 GMT
Resent-Message-Id: <200701150310.l0F3ACb8092594@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-ports-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Tai-hwa Liang <avatar@mmlab.cse.yzu.edu.tw>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 7A16516A417
	for <FreeBSD-gnats-submit@freebsd.org>;
	Mon, 15 Jan 2007 03:01:16 +0000 (UTC)
	(envelope-from avatar@www.mmlab.cse.yzu.edu.tw)
Received: from www.mmlab.cse.yzu.edu.tw (www.mmlab.cse.yzu.edu.tw
	[140.138.150.166])
	by mx1.freebsd.org (Postfix) with ESMTP id 4350313C4C3
	for <FreeBSD-gnats-submit@freebsd.org>;
	Mon, 15 Jan 2007 03:01:15 +0000 (UTC)
	(envelope-from avatar@www.mmlab.cse.yzu.edu.tw)
Received: by www.mmlab.cse.yzu.edu.tw (qmail, from userid 1000)
	id 261258C99DE; Mon, 15 Jan 2007 10:39:31 +0800 (CST)
Message-Id: <20070115023932.261258C99DE@www.mmlab.cse.yzu.edu.tw>
Date: Mon, 15 Jan 2007 10:39:31 +0800 (CST)
From: Tai-hwa Liang <avatar@mmlab.cse.yzu.edu.tw>
To: FreeBSD-gnats-submit@FreeBSD.org
X-Send-Pr-Version: 3.113
Cc: 
Subject: ports/107937: jailed net/isc-dhcp3-server wouldn't run with an
	immutable /etc/resolv.conf
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Tai-hwa Liang <avatar@mmlab.cse.yzu.edu.tw>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Jan 2007 03:10:13 -0000


>Number:         107937
>Category:       ports
>Synopsis:       jailed net/isc-dhcp3-server wouldn't run with an immutable /etc/resolv.conf
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 15 03:10:12 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Tai-hwa Liang
>Release:        FreeBSD 6.2-PRELEASE i386
>Organization:
>Environment:
Tested on 6.2-PRELEASE and 6-STABLE.
	
>Description:
	
	Given that "cp -p" will preserve immutable flag as well,
/usr/local/etc/rc.d/isc-dhcpd only bails out if /etc/resolv.conf is
immutable.
>How-To-Repeat:
	# chflags schg /etc/resolv.conf
	# /usr/local/etc/rc.d/isc-dhcpd start
	
>Fix:

	Please consider the following patch, thanks.

--- isc-dhcpd.in	Mon Nov  6 09:17:15 2006
+++ isc-dhcpd.in.new	Mon Jan 15 10:19:16 2007
@@ -106,6 +106,7 @@
 			if [ -e ${_entry} ] &&
 			   ! precious ${_entry} &&
 			   ! lsmod ${_user} ${_group} ${_entry} &&
+			   ! safe_run ${_rc} chflags noschg ${_entry} &&
 			   ! safe_run ${_rc} chown ${_usergroup} ${_entry}; then
 				warn "unable to change permissions of ${_entry}"
 				_rc=1
@@ -175,6 +176,10 @@
 	_rc=0
 	for _entry; do
 		if [ -f ${_entry} ]; then
+			if ! safe_run ${_rc} chflags noschg ${_entry}; then
+				warn "unable to change flags of ${_entry}"
+				_rc=1
+			fi
 			if ! safe_run ${_rc} rm -f ${_entry}; then
 				warn "unable to remove file ${_entry}"
 				_rc=1
@@ -182,6 +187,10 @@
 		elif [ -d ${_entry} ] &&
 		     ! precious ${_entry} &&
 		     ! mounted ${_entry}; then
+			if ! safe_run ${_rc} chflags -R noschg ${_entry}; then
+				warn "unable to change flags of ${_entry}"
+				_rc=1
+			fi
 			if ! safe_run ${_rc} rm -rf ${_entry}; then
 				warn "unable to remove directory ${_entry}"
 				_rc=1
>Release-Note:
>Audit-Trail:
>Unformatted: