Date: Sun, 15 Jan 2012 19:56:01 +0100 From: Alex Dupre <ale@FreeBSD.org> To: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/print/pdflib Makefile pkg-plist ports/print/pdflib/files patch-configure ports/print/pdflib-perl Makefile Message-ID: <4F132141.8020806@FreeBSD.org> In-Reply-To: <20120114092733.GA45406@bonjour.sunpoet.net> References: <201201130917.q0D9HfbF078269@repoman.freebsd.org> <20120114092733.GA45406@bonjour.sunpoet.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Sunpoet Po-Chuan Hsieh ha scritto: > Hi Alex, > > I was confused by the conditional PERL OPTIONS. > > .if defined(WITH_PERL) > OPTIONS= PERL "Build perl bindings" on > .else > OPTIONS= PERL "Build perl bindings" off > .endif > > If WITH_PERL defined somewhere (pdflib-perl, make.conf or portconf), > the perl option should already be turned on by options framework. It > seems that a default-off perl option (line 4) is enough. From a functional point of view: yes, it's enough. From a user-experience point of view, if you install pdflib-perl I think you'll be confused if the PERL option is not selected. -- Alex Dupre
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F132141.8020806>