From owner-cvs-all@FreeBSD.ORG Sun Jun 18 08:21:55 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 687FD16A479; Sun, 18 Jun 2006 08:21:55 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from transport.cksoft.de (transport.cksoft.de [62.111.66.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 38C5043D48; Sun, 18 Jun 2006 08:21:54 +0000 (GMT) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from transport.cksoft.de (localhost [127.0.0.1]) by transport.cksoft.de (Postfix) with ESMTP id 0FE661FFDEE; Sun, 18 Jun 2006 10:21:52 +0200 (CEST) Received: by transport.cksoft.de (Postfix, from userid 66) id 74DF31FFDED; Sun, 18 Jun 2006 10:21:48 +0200 (CEST) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 8F1594448D6; Sun, 18 Jun 2006 08:20:57 +0000 (UTC) Date: Sun, 18 Jun 2006 08:20:57 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Sam Leffler In-Reply-To: <4494FDF5.1070901@errno.com> Message-ID: <20060618080019.B60374@maildrop.int.zabbadoz.net> References: <200606171757.k5HHvahf087725@repoman.freebsd.org> <4494FDF5.1070901@errno.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Virus-Scanned: by AMaViS cksoft-s20020300-20031204bz on transport.cksoft.de Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andre Oppermann , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet tcp_var.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jun 2006 08:21:55 -0000 On Sun, 18 Jun 2006, Sam Leffler wrote: > Andre Oppermann wrote: >> andre 2006-06-17 17:57:36 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/netinet tcp_var.h >> Log: >> Rearrange fields in struct syncache and syncache_head to make them more >> cache line friendly. > > Got any benchmarks to back this up? Or perhaps it was just the smiley > face your cache lines gave you :) That indeed is a good question. From looking at the patch I can see a new lock introduced while there are other people working on reducing locking and locking overhead in our network stack trying different strategies. I hadn't seen a patch or any numbers in this months arch@ or net@ archives (maybe I missed it?). At the current phase of network stack hacking we should take the time to get these kind of changes benchmarked under various loads from different people or at least give them the chance to do so so nobody can complain afterwards. At least if one wants to claim performance improvements. just my 2ct -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT