From owner-cvs-src@FreeBSD.ORG Wed Sep 15 23:39:22 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3FC2D16A4CE; Wed, 15 Sep 2004 23:39:22 +0000 (GMT) Received: from green.homeunix.org (pcp04368961pcs.nrockv01.md.comcast.net [69.140.212.7]) by mx1.FreeBSD.org (Postfix) with ESMTP id C058843D31; Wed, 15 Sep 2004 23:39:21 +0000 (GMT) (envelope-from green@green.homeunix.org) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.1/8.13.1) with ESMTP id i8FNdKJp056566; Wed, 15 Sep 2004 19:39:20 -0400 (EDT) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.1/8.13.1/Submit) id i8FNdFO6056565; Wed, 15 Sep 2004 19:39:15 -0400 (EDT) (envelope-from green) Date: Wed, 15 Sep 2004 19:39:15 -0400 From: Brian Fundakowski Feldman To: Julian Elischer Message-ID: <20040915233915.GI36708@green.homeunix.org> References: <200409152326.i8FNQnOV009184@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200409152326.i8FNQnOV009184@repoman.freebsd.org> User-Agent: Mutt/1.5.6i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 gdb_machdep.c src/sys/i386/include db_machdep.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Sep 2004 23:39:22 -0000 On Wed, Sep 15, 2004 at 11:26:49PM +0000, Julian Elischer wrote: > julian 2004-09-15 23:26:49 UTC > > FreeBSD src repository > > Modified files: > sys/i386/i386 gdb_machdep.c > sys/i386/include db_machdep.h > Log: > Fix breakpoint handling for i386. > not sure yet about 5.x... MFC if needed. > Also fixes small problems with examining some registers and > some specific gdb transfer problems. > > As the patch says: > This is not a pretty patch and only meant as a temporary > fix until a better solution is committed. > > PR: i386/71715 > Submitted by: Stephan Uphoff > MFC after: 1 week What about this change I'm still using with KDB so that break points don't crash my system as immediately? --- include/db_machdep.h 10 Jul 2004 23:47:19 -0000 1.18 +++ include/db_machdep.h 27 Aug 2004 23:14:12 -0000 @@ -35,7 +35,7 @@ typedef vm_offset_t db_addr_t; /* address - unsigned */ typedef int db_expr_t; /* expression - signed */ -#define PC_REGS() ((db_addr_t)kdb_thrctx->pcb_eip) +#define PC_REGS() ((db_addr_t)kdb_frame->tf_eip) #define BKPT_INST 0xcc /* breakpoint instruction */ #define BKPT_SIZE (1) /* size of breakpoint inst */ -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\