Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 30 May 2003 23:05:12 +0300
From:      Ruslan Ermilov <ru@FreeBSD.org>
To:        John Baldwin <jhb@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/security/mac_mls mac_mls.c
Message-ID:  <20030530200512.GE60607@sunbay.com>
In-Reply-To: <XFMail.20030530142510.jhb@FreeBSD.org>
References:  <200305301702.h4UH2bHi052360@repoman.freebsd.org> <XFMail.20030530142510.jhb@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--V4b9U9vrdWczvw78
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 30, 2003 at 02:25:10PM -0400, John Baldwin wrote:
>=20
> On 30-May-2003 Robert Watson wrote:
> > rwatson     2003/05/30 10:02:37 PDT
> >=20
> >   FreeBSD src repository
> >=20
> >   Modified files:
> >     sys/security/mac_mls mac_mls.c=20
> >   Log:
> >   Make sure all character pointers are properly initialized; this was
> >   mismerged from the MAC tree, and didn't get picked up because warnings
> >   are not normally fatal in per-module builds, only when they are linked
> >   into a kernel (such as LINT).
>=20
> Can someone make module builds use the same warning flags and
> settings as kernel builds please?  This same scenario has happened
> numerous times now.
>=20
This is not easy.  For the kernel build, we have NORMAL_C and
NORMAL_C_NOWERROR (the former includes WERROR?=3D -Werror).
There are lot of files in sys/conf/files* that are marked with
"nowerror", and I'm sure they will break to compile as modules
with this patch, e.g., the acpi module has lot of files with
warnings:

%%%
Index: kern.mk
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /home/ncvs/src/sys/conf/kern.mk,v
retrieving revision 1.34
diff -u -r1.34 kern.mk
--- kern.mk	3 May 2003 18:05:56 -0000	1.34
+++ kern.mk	30 May 2003 19:57:00 -0000
@@ -9,6 +9,8 @@
 CWARNFLAGS?=3D	-Wall -Wredundant-decls -Wnested-externs -Wstrict-prototype=
s \
 		-Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual \
 		-fformat-extensions -std=3Dc99
+WERROR?=3D	-Werror
+
 #
 # The following flags are next up for working on:
 #	-W
Index: kern.pre.mk
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /home/ncvs/src/sys/conf/kern.pre.mk,v
retrieving revision 1.24
diff -u -r1.24 kern.pre.mk
--- kern.pre.mk	28 Feb 2003 21:59:14 -0000	1.24
+++ kern.pre.mk	30 May 2003 19:57:15 -0000
@@ -48,7 +48,6 @@
 .endif
 .endif
 DEFINED_PROF=3D	${PROF}
-WERROR?=3D	-Werror
=20
 # Put configuration-specific C flags last (except for ${PROF}) so that they
 # can override the others.
Index: kmod.mk
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /home/ncvs/src/sys/conf/kmod.mk,v
retrieving revision 1.137
diff -u -r1.137 kmod.mk
--- kmod.mk	3 Mar 2003 22:51:22 -0000	1.137
+++ kmod.mk	30 May 2003 19:55:07 -0000
@@ -70,7 +70,7 @@
=20
 .SUFFIXES: .out .o .c .cc .cxx .C .y .l .s .S
=20
-CFLAGS+=3D	${COPTS} -D_KERNEL ${CWARNFLAGS}
+CFLAGS+=3D	${COPTS} -D_KERNEL ${CWARNFLAGS} ${WERROR}
 CFLAGS+=3D	-DKLD_MODULE
=20
 # Don't use any standard or source-relative include directories.
%%%

--=20
Ruslan Ermilov		Sysadmin and DBA,
ru@sunbay.com		Sunbay Software AG,
ru@FreeBSD.org		FreeBSD committer.

--V4b9U9vrdWczvw78
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)

iD8DBQE+17l4Ukv4P6juNwoRAi6LAJ0b9rOuoqZJqdahjHxI5pwAvOOvGQCdEfdC
qb4Rr3AuXGE8F5QV5vdncfE=
=VWGE
-----END PGP SIGNATURE-----

--V4b9U9vrdWczvw78--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030530200512.GE60607>