From owner-cvs-all@FreeBSD.ORG Fri May 30 13:05:31 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4FAE837B401; Fri, 30 May 2003 13:05:31 -0700 (PDT) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id E565943F85; Fri, 30 May 2003 13:05:27 -0700 (PDT) (envelope-from ru@whale.sunbay.crimea.ua) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h4UK5DEd076119 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 30 May 2003 23:05:19 +0300 (EEST) (envelope-from ru@whale.sunbay.crimea.ua) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h4UK5CVg076110; Fri, 30 May 2003 23:05:12 +0300 (EEST) (envelope-from ru) Date: Fri, 30 May 2003 23:05:12 +0300 From: Ruslan Ermilov To: John Baldwin Message-ID: <20030530200512.GE60607@sunbay.com> References: <200305301702.h4UH2bHi052360@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="V4b9U9vrdWczvw78" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/security/mac_mls mac_mls.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 May 2003 20:05:31 -0000 --V4b9U9vrdWczvw78 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 30, 2003 at 02:25:10PM -0400, John Baldwin wrote: >=20 > On 30-May-2003 Robert Watson wrote: > > rwatson 2003/05/30 10:02:37 PDT > >=20 > > FreeBSD src repository > >=20 > > Modified files: > > sys/security/mac_mls mac_mls.c=20 > > Log: > > Make sure all character pointers are properly initialized; this was > > mismerged from the MAC tree, and didn't get picked up because warnings > > are not normally fatal in per-module builds, only when they are linked > > into a kernel (such as LINT). >=20 > Can someone make module builds use the same warning flags and > settings as kernel builds please? This same scenario has happened > numerous times now. >=20 This is not easy. For the kernel build, we have NORMAL_C and NORMAL_C_NOWERROR (the former includes WERROR?=3D -Werror). There are lot of files in sys/conf/files* that are marked with "nowerror", and I'm sure they will break to compile as modules with this patch, e.g., the acpi module has lot of files with warnings: %%% Index: kern.mk =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/sys/conf/kern.mk,v retrieving revision 1.34 diff -u -r1.34 kern.mk --- kern.mk 3 May 2003 18:05:56 -0000 1.34 +++ kern.mk 30 May 2003 19:57:00 -0000 @@ -9,6 +9,8 @@ CWARNFLAGS?=3D -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototype= s \ -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual \ -fformat-extensions -std=3Dc99 +WERROR?=3D -Werror + # # The following flags are next up for working on: # -W Index: kern.pre.mk =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/sys/conf/kern.pre.mk,v retrieving revision 1.24 diff -u -r1.24 kern.pre.mk --- kern.pre.mk 28 Feb 2003 21:59:14 -0000 1.24 +++ kern.pre.mk 30 May 2003 19:57:15 -0000 @@ -48,7 +48,6 @@ .endif .endif DEFINED_PROF=3D ${PROF} -WERROR?=3D -Werror =20 # Put configuration-specific C flags last (except for ${PROF}) so that they # can override the others. Index: kmod.mk =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/sys/conf/kmod.mk,v retrieving revision 1.137 diff -u -r1.137 kmod.mk --- kmod.mk 3 Mar 2003 22:51:22 -0000 1.137 +++ kmod.mk 30 May 2003 19:55:07 -0000 @@ -70,7 +70,7 @@ =20 .SUFFIXES: .out .o .c .cc .cxx .C .y .l .s .S =20 -CFLAGS+=3D ${COPTS} -D_KERNEL ${CWARNFLAGS} +CFLAGS+=3D ${COPTS} -D_KERNEL ${CWARNFLAGS} ${WERROR} CFLAGS+=3D -DKLD_MODULE =20 # Don't use any standard or source-relative include directories. %%% --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer. --V4b9U9vrdWczvw78 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE+17l4Ukv4P6juNwoRAi6LAJ0b9rOuoqZJqdahjHxI5pwAvOOvGQCdEfdC qb4Rr3AuXGE8F5QV5vdncfE= =VWGE -----END PGP SIGNATURE----- --V4b9U9vrdWczvw78--