From owner-freebsd-current@FreeBSD.ORG  Tue Nov  9 18:45:13 2010
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4597F1065670;
	Tue,  9 Nov 2010 18:45:13 +0000 (UTC) (envelope-from avg@freebsd.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 5D7C58FC26;
	Tue,  9 Nov 2010 18:45:11 +0000 (UTC)
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
	[212.40.38.101])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id UAA29771;
	Tue, 09 Nov 2010 20:45:03 +0200 (EET) (envelope-from avg@freebsd.org)
Message-ID: <4CD996AF.2070300@freebsd.org>
Date: Tue, 09 Nov 2010 20:45:03 +0200
From: Andriy Gapon <avg@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.2.11) Gecko/20101021 Lightning/1.0b2 Thunderbird/3.1.5
MIME-Version: 1.0
To: Alan Cox <alc@rice.edu>
References: <4CA0DA49.2090006@freebsd.org> <4CA3A48A.5070300@freebsd.org>
	<4CA3BD1E.5070807@rice.edu> <4CA5911E.3000101@freebsd.org>
	<4CAE0060.7050607@freebsd.org> <4CAECC4D.90707@rice.edu>
	<4CD1AA45.7000504@freebsd.org> <4CD1AD80.2090903@rice.edu>
	<4CD1D4AA.3060309@freebsd.org> <4CD8FFFF.3070106@rice.edu>
In-Reply-To: <4CD8FFFF.3070106@rice.edu>
X-Enigmail-Version: 1.1.2
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Alan Cox <alc@freebsd.org>, freebsd-current@freebsd.org
Subject: Re: minidump size on amd64
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Nov 2010 18:45:13 -0000

on 09/11/2010 10:02 Alan Cox said the following:
> The kernel portion of the patch looks correct.  If I were to make one stylistic
> suggestion, it would be to make the control flow of the outer and inner loops as
> similar as possible, that is,
> 
>    for (...
>       if ((pdp[i] & PG_V) == 0) {
>          ...
>          continue;
>       }
>       if ((pdp[i] & PG_PS) != 0) {
>          ...
>          continue;
>       }
>       for (...
>          if ((pd[j] & PG_V) == 0)
>             continue;
>          if ((pd[j] & PG_PS) != 0) {
>             ...
>             continue;
>          }
>          for (...
>             if ((pt[x] & PG_V) == 0)
>                continue;
>             ...
> 
> I think this would make the code a little easier to follow.

This is a very nice suggestion, thank you.
Besides the uniformity some horizontal space is saved too :-)
Updated patch (only kernel part) is here:
http://people.freebsd.org/~avg/amd64-minidump.5.diff

-- 
Andriy Gapon