Date: Tue, 14 Jan 2003 12:46:32 +0100 From: Thomas Moestl <tmoestl@gmx.net> To: Terry Lambert <tlambert2@mindspring.com> Cc: Martin Blapp <mb@imp.ch>, current@freebsd.org, net@freebsd.org Subject: Re: PANIC in tcp_syncache.c sonewconn() line 562 Message-ID: <20030114114632.GA280@crow.dom2ip.de> In-Reply-To: <3E23EB97.694EC9BB@mindspring.com> References: <20030113173957.T73725@levais.imp.ch> <20030113215318.GA278@crow.dom2ip.de> <20030114100620.W76016@levais.imp.ch> <3E23EB97.694EC9BB@mindspring.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2003/01/14 at 02:51:03 -0800, Terry Lambert wrote: > Martin Blapp wrote: > > Can you commit this ? The fix looks appropriate, but the manpage should > > also be changed to reflect the change. > > > > ERRORS > > Listen() will fail if: > > > > [EBADF] The argument s is not a valid descriptor. > > [ENOTSOCK] The argument s is not a socket. > > [EOPNOTSUPP] The socket is not of a type that > > supports the operation listen(). > > [EINVAL] Listen() has been already called on the socket. > > > > Any objections from others ? > > It seems to me that calling listen() on a socket to change the > listen queue depth is a reasonable thing to do; this is true > before it's bound, after it's bound, before listen() has been > called on it, and after listen() has been called on it once (or > more). > > Am I missing something here? Is there a good technical reason > to not permit an application to change the listen queue depth? > Or is there some way that an application can do this, using a > call other than listen()? > > That it causes a panic when the SYN cache is enabled isn't really > a technical reason, it's a circumstantial reason. The manpage change does not reflect the change in the patch :) It should be: [EINVAL] The socket is connected. - Thomas -- Thomas Moestl <tmoestl@gmx.net> http://www.tu-bs.de/~y0015675/ <tmm@FreeBSD.org> http://people.FreeBSD.org/~tmm/ PGP fingerprint: 1C97 A604 2BD0 E492 51D0 9C0F 1FE6 4F1D 419C 776C To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030114114632.GA280>