From owner-svn-src-all@FreeBSD.ORG Tue Apr 16 13:20:20 2013 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 663A2E9E; Tue, 16 Apr 2013 13:20:20 +0000 (UTC) (envelope-from keramida@ceid.upatras.gr) Received: from tux-cave.hellug.gr (tux-cave.hellug.gr [195.134.99.74]) by mx1.freebsd.org (Postfix) with ESMTP id D4321A40; Tue, 16 Apr 2013 13:20:19 +0000 (UTC) X-Spam-Status: No X-Hellug-MailScanner-From: keramida@ceid.upatras.gr X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-2.9, required 5, autolearn=not spam, ALL_TRUSTED -1.00, BAYES_00 -1.90) X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-ID: r3GDK9nL014108 Received: from saturn.laptop (217-162-217-29.dynamic.hispeed.ch [217.162.217.29]) (authenticated bits=0) by tux-cave.hellug.gr (8.14.3/8.14.3/Debian-9.4) with ESMTP id r3GDK9nL014108 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 16 Apr 2013 16:20:17 +0300 Received: from saturn.laptop (localhost [127.0.0.1]) by saturn.laptop (8.14.4/8.14.4/Debian-2.1ubuntu1) with ESMTP id r3GDK4An027845 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 16 Apr 2013 15:20:04 +0200 Received: (from keramida@localhost) by saturn.laptop (8.14.4/8.14.4/Submit) id r3GDK3sI027837; Tue, 16 Apr 2013 15:20:03 +0200 X-Authentication-Warning: saturn.laptop: keramida set sender to keramida@ceid.upatras.gr using -f From: keramida@ceid.upatras.gr (Giorgos Keramidas) To: Dimitry Andric Subject: Re: svn commit: r246880 - in head: lib/libsm libexec/mail.local libexec/smrsh share/mk usr.bin/vacation usr.sbin/sendmail References: <201302162017.r1GKHVdY022667@svn.freebsd.org> <87a9ozayzk.fsf@saturn.laptop> <516D13C5.70900@FreeBSD.org> Date: Tue, 16 Apr 2013 15:20:03 +0200 In-Reply-To: <516D13C5.70900@FreeBSD.org> (Dimitry Andric's message of "Tue, 16 Apr 2013 11:03:01 +0200") Message-ID: <87vc7m629o.fsf@saturn.laptop> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@FreeBSD.org, Gregory Shapiro , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Apr 2013 13:20:20 -0000 On Tue, 16 Apr 2013 11:03:01 +0200, Dimitry Andric wrote: > On 2013-04-16 06:19, =CE=93=CE=B9=CF=8E=CF=81=CE=B3=CE=BF=CF=82 =CE=9A=CE= =B5=CF=81=CE=B1=CE=BC=CE=AF=CE=B4=CE=B1=CF=82 wrote: >> On Sat, 16 Feb 2013 20:17:31 +0000 (UTC), Dimitry Andric wrote: > ... >>> Since clang 3.2 now has an option to suppress warnings about implici= tly >>> promoted K&R parameters, remove the workarounds added for sendmail >>> components in r228558. > ... >> The part of the commit that removes NO_WERROR.clang for usr.sbin/sendmai= l/ >> breaks the build of Sendmail with -DSASL. I just tried rebuilding Sendm= ail >> with the following in "/etc/make.conf": >> >> # Build Sendmail with SASL support. >> SENDMAIL_CFLAGS ?=3D -I/usr/local/include -DSASL=3D20126 >> SENDMAIL_LDFLAGS ?=3D -L/usr/local/lib >> SENDMAIL_LDADD ?=3D -lsasl2 >> >> The warnings that usersmtp.c still triggers when -DSASL is used are: >> >> : cc -O2 -pipe -I/usr/src/usr.sbin/sendmail/../../contrib/sendmail/src >> -I/usr/src/usr.sbin/sendmail/../../contrib/sendmail/include >> -I. -DNEWDB -DNIS -DTCPWRAPPERS -DMAP_REGEX -DDNSMAP -DNETINET6 >> -DSTARTTLS -D_FFR_TLS_1 -I/usr/local/include -DSASL=3D20126 -std=3Dgnu99 >> -Qunused-arguments -fstack-protector -Wsystem-headers >> -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int >> -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality >> -Wno-unused-function -Wno-conversion -Wno-switch -Wno-switch-enum >> -Wno-knr-promoted-parameter -Wno-parentheses -c >> /usr/src/usr.sbin/sendmail/../../contrib/sendmail/src/usersmtp.c >> : >> /usr/src/usr.sbin/sendmail/../../contrib/sendmail/src/usersmtp.c:1797:50: >> warning: incompatible pointer types passing 'void ()' to parameter of >> type 'void (*)(char *, bool, MAILER *, struct >> : mailer_con_info *, ENVELOPE *)' [-Wincompatible-pointer-types] >> : smtpresult =3D reply(m, mci, e, TimeOuts.to_auth, getsasldata,= NULL, >> : ^~~~~~~~~~~ > > Have you tried the patch I posted here? > > http://lists.freebsd.org/pipermail/freebsd-current/2013-March/040634.html > > If people feel this is the right approach, I am happy to commit it. If > people prefer to just shut up warnings, I am happy with that too. Confirmed. This fixes the build of usr.sbin/sendmail even without the NO_WERROR.clang=3D option. Thanks :-)