Date: Tue, 17 Feb 1998 17:23:47 -0800 From: "Jordan K. Hubbard" <jkh@time.cdrom.com> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-lib@FreeBSD.ORG, jkh@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/gen getpass.c Message-ID: <20692.887765027@time.cdrom.com> In-Reply-To: Your message of "Wed, 18 Feb 1998 09:49:26 %2B1100." <199802172249.JAA29472@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
> side effect, to (uncleanly) back out revisions 1.2 and 1.3. Revisions 1.2 > and 1.3 break the signal handling for callers that ignore signals, e.g., > login(1) and passwd(1). Login was kludged to not ignore signals for > the getpass() call and in surrounding code so that the broken getpass() > didn't affect it. It's not clear what happens if a previously-ignored > signal occurs while the surrounding code is running. A correct version > of revisions 1.2 and 1.3 would only catch signals if signals are being > defaulted. It's not clear what it should do if signals are being caught. > Keeping the historical behaviour would be safest. *Blink*. Which would be? Sorry, my universal translator appears to be on the blink and I can't really parse the above - when I asked it to do so for me, it just spat out: efeito lateral, (uncleanly) à parte traseira para fora das revisões 1,2 e 1,3. As revisões 1,2 e 1,3 quebram o sinal que segura para os chamadores que ignoram os sinais, por exemplo, login(1) e passwd(1). O início de uma sessão era kludged para não ignorar sinais para a chamada do getpass() e em código circunvizinho de modo que o getpass() quebrado não o afetasse. Não está desobstruído o que acontece se um sinal precedente-ignorado ocorrer quando o código circunvizinho funcionar. Uma versão correta das revisões 1,2 e 1,3 travaria somente sinais se os sinais fossem optados. Não está desobstruída o que deve fazer se os sinais estiverem sendo travados. Manter o comportamento histórico seria o mais seguro. Which appears to be portuguese or something. No doubt about it, I need to get this thing fixed! :-) Jordan To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20692.887765027>