From owner-freebsd-ports@freebsd.org Fri May 1 19:22:30 2020 Return-Path: Delivered-To: freebsd-ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B18B22DDD45; Fri, 1 May 2020 19:22:30 +0000 (UTC) (envelope-from matthias.andree@gmx.de) Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass Class 2 CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49DMZn6xZLz41q6; Fri, 1 May 2020 19:22:25 +0000 (UTC) (envelope-from matthias.andree@gmx.de) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1588360943; bh=KBpmQqPJ++Cg2mJIvkSFge21MwxTv7ep6du/WeGn3Is=; h=X-UI-Sender-Class:To:References:From:Cc:Subject:Date:In-Reply-To; b=JoKyCMsM/givlvDq+uNXN6CAhHlpibYZ7C2OAsKpil5QJ5S+5oJJHX0LaDraz1aM7 pvb3GSIPecl0aR2EKASEitVhNd4MExgZe0r/pHmqRpd2L7H/ai845y6oZ56ZE9VIqn 2wtzJQScEiSciigqL79txbwLw3d9LcXmwdeRAVS0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from mandree.no-ip.org ([217.224.124.127]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MFKGP-1jOEVi1Lar-00Fmih; Fri, 01 May 2020 21:22:23 +0200 Received: from ryzen.an3e.de (localhost [IPv6:::1]) by ryzen.an3e.de (Postfix) with ESMTP id 9B6E3120A99; Fri, 1 May 2020 21:22:22 +0200 (CEST) To: Guido Falsi , gnome References: <344878e8-e885-744a-df10-9af61017cbd7@FreeBSD.org> From: Matthias Andree Cc: freebsd-ports@freebsd.org, portmgr Subject: Mk/Uses/gnome.mk INSTALLS_ICONS broken (was: Error testing port in poudriere caused by pkg not running deinstall scripts) Message-ID: Date: Fri, 1 May 2020 21:22:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <344878e8-e885-744a-df10-9af61017cbd7@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Provags-ID: V03:K1:QQC8RDphBjn1VQ12LfBrjIyua5ojj8dz0RcwDt2lM9Z7MAfTPGD JGRpPxxlyS+saya1+6/Ojg+A/D5sDk5CwDIaCcfrvEg3JlUYruBNLBp5C/HGuNqDAMpYyo2 QQizG8aIZvnAdwwlysjS11HDJd+iTavT+UCP7/3MmkuHOIlXDy5u6g7e+ACQJtocgdOvCmA tuyX9f5wKyqs8m8rsl6ig== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:gBmIiZ4Iwdw=:1mA85SfBODIEVJf4rIWAEP +DBvQUugH9zw07VcqgJk/AZLJ/HwgC4MqW0+7J2XeJfdbjcK/D5dJDpJdx94DQCPrljbUo+9M zuhPsysGqmG+0C9SYrPsV+jl4UVUi0XRKx91O8oBneTIkvuULFUqxqpqcN8IDXJXKzjhJO8lW D+7fTvfnUE8nLscZp5aeDJTX3BYuJYUut8D6UkyfBblcwlT4dee1tWhaOhdoA62T2GGqxidjo FotCQfQoXEzpeAdZI0CNNN5ZUpsb9XOsG+mCwJym9gJeO11JFcYX96WbfMcSnN7uePAT/KCcw i9tF5yQB6GpToH5xMOSW3YQ3IDU9KdeVVU1pCuzKXcRDWGS/RzVhVTKPhaTR70vB2BcCpD1fN LQtWfB8PVm6R+QXUDPnljNJklnd5NMVf4RNFOM5adp1irmztcm9IGMEP1/WaxdNN8zAalhhvM lQtcXvh4Oa/8Y1jBHnsBsuf/qIUruSX2bcVnVyuKB+gv7liv5mqmTgQQB1yoMVjXG5rrx7/iR W0cnbfIhYGJshPRwC0SU3B7vr8F24FcpohwZrCLBYih9ud8eiVMRjPYC8cRBpsQej2rVAiClj Y52tgpQTEHnlBukOL6amMSO45OohPRQ0gbLlP5k3RqewE7Q0jVe0k3cnNsHftUzrO29zqgBb1 l2xoY9APscPJ/Qa6HB0OfHInUBahxy76I9CDV7lMP0NjrLlSVGg9Uoj2QViUVy0Wna/3RNhi7 SUmH63rkcfvkLq4/MYEaxkXaZRS8Vqm54/BarItA/i7F0mAJRc9j2N6Oh8nj2obud+qzWHyCX 0vC4wIkngWGruHpBjHCtUPrzZXMyA76Qz8MPfp5VudLT7XVpnj0aHXSxdxY+pjtfE5v09tUQs MuxG5NmRK7jAFqxCtMtrFa6HwcbMbCDLggK4aCkWDi0a/g3ttcb5i5tDKd75/XeszkKOVQrld UmES5/u/c+bz9RazbnJoqG8a61P3IElLM/O1VCCgf/P6Z5MfC56Q1um794NJyC9XATob6B1b0 VDNufc9Dly6Er9xqhcVrdG14AeRtBmF4loupOMILmOScNqFzoqP8Pli4LTCIBiB2CeIM87Jmg Vt6r7I4jtdYcG/oN488XjrWbTjPUkjdzyvVKVEB/0epl4tPDDmL6Jlbg0Iut1VGEzz5IfVTV7 OW0Cy7NeZzoJa9uJnuMxCQEpdS5U1oBIOeo089q94rAWTLFieD6cfXxQvQI9ac1gkSxmpNtuR ktEu6i3cUfxUN6Lkz X-Rspamd-Queue-Id: 49DMZn6xZLz41q6 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmx.net header.s=badeba3b8450 header.b=JoKyCMsM; dmarc=none; spf=pass (mx1.freebsd.org: domain of matthias.andree@gmx.de designates 212.227.17.22 as permitted sender) smtp.mailfrom=matthias.andree@gmx.de X-Spamd-Result: default: False [-2.60 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmx.net:s=badeba3b8450]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:212.227.17.0/27]; FREEMAIL_FROM(0.00)[gmx.de]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[gmx.de]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[3]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[gmx.net:+]; IP_SCORE_FREEMAIL(0.00)[]; IP_SCORE(0.00)[ip: (-6.47), ipnet: 212.227.0.0/16(-1.21), asn: 8560(2.05), country: DE(-0.02)]; RCVD_IN_DNSWL_LOW(-0.10)[22.17.227.212.list.dnswl.org : 127.0.3.1]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmx.de]; ASN(0.00)[asn:8560, ipnet:212.227.0.0/16, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[127.124.224.217.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 May 2020 19:22:30 -0000 Am 01.05.20 um 19:49 schrieb Guido Falsi: > hi, > > While testing an update to xfce ports I have got this error in poudrier= e: > > =3D>> Checking for extra files and directories > =3D>> Error: Files or directories removed: > share/icons/hicolor/icon-theme.cache > > And could not find any cause for it. > > This file should be managed by the INSTALLS_ICONS port variable, which > adds post-install and post-deinstall commands. > > My suspect is the post-deinstall command is not being run properly for > some reason causing this error. > > Could this be correct? How can I verify this? > I've filed https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D246102 for= this: You're hunting the wrong fault, and poudriere reports a genuine bug (which is not in your package). Read again: the complaint is that the port deinstallation REMOVES (not: LEAVES BEHIND) the prior icon-theme.cache. I've debugged this, the INSTALLS_ICONS from Mk/Uses/gnome.mk adds a @rmtry (i. e. delete, but don't complain if missing) for the cache file, and topmost in the PLIST, so the deinstallation of ANY package using that macro will first update and then nuke the cache file. Proof below. Conclusion: Mk/Uses/gnome.mk is broken (in particular the gnome-post-icons: target). Here's how: # pkg -ddd delete xfce4-taskmanager # (was version 1.2.3): > [...] > DBG(1)[59116]> Deleting file: > 'usr/local/share/locale/zh_TW/LC_MESSAGES/xfce4-taskmanager.mo' > DBG(1)[59116]> Adding to deletion > usr/local/share/locale/zh_TW/LC_MESSAGES/ > [1/1] Deleting files for xfce4-taskmanager-1.2.3... done > DBG(3)[59116]> Scripts: executing > --- BEGIN --- > set -- xfce4-taskmanager-1.2.3 > /usr/local/bin/gtk-update-icon-cache -q -f > /usr/local/share/icons/hicolor 2>/dev/null || /usr/bin/true > > Scripts: --- END --- > DBG(3)[59119]> Scripts: executing lua > --- BEGIN --- > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 file =3D pkg.prefixed_path("= share/icons/hicolor/icon-theme.cache") > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -- ignore the return value a= nd the error > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ret, err =3D os.remove(file)= > Scripts: --- END --- and after that, /usr/local/share/icons/hicolor/icon-theme.cache is missin= g. Meaning that the deinstallation of ANY (but the last installed) package that uses INSTALLS_ICONS deletes the icon-theme.cache files in all directories where they had placed icons.