Date: 04 Sep 2003 09:16:54 +0100 From: Doug Rabson <dfr@nlsystems.com> To: "M. Warner Losh" <imp@bsdimp.com> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_sis.c if_sisreg.h Message-ID: <1062663414.86530.15.camel@herring.nlsystems.com> In-Reply-To: <20030903.194045.71089689.imp@bsdimp.com> References: <200309030740.h837e4qS056204@repoman.freebsd.org> <20030903.194045.71089689.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 2003-09-04 at 02:40, M. Warner Losh wrote: > In message: <200309030740.h837e4qS056204@repoman.freebsd.org> > Poul-Henning Kamp <phk@FreeBSD.org> writes: > : We can't update the device description in attach (why not ?), so > : we device_print() what we find. > > You can. However, we use the description after PROBE, and changing it > in attach doesn't cause us to go back and unprint it, so it does > little good. We could fix this, and the resource allocation issues, > by printing things after a successful attach, but that would likely > confuse people. We could also move the print to after attach. That might alleviate some of the confusion when an attach fails - in the log, it looks like the device exists. On the other hand, that wouldn't work - some attach methods print stuff and many create probe and attach other stuff. For specific drivers, if they really want to change the device description in attach (why not do it in probe like every other driver), they could mark the device as quiet and then explicitly call device_print_child after they have massaged the device.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1062663414.86530.15.camel>