Date: Fri, 16 Aug 2019 17:37:56 -0700 From: John Baldwin <jhb@FreeBSD.org> To: gljennjohn@gmail.com, current@freebsd.org Subject: Re: problem with LOCAL_MODULES Message-ID: <e1010b9b-26a6-9ce6-873c-10e503dc2030@FreeBSD.org> In-Reply-To: <20190816120524.21b7fd19@ernst.home> References: <20190816120524.21b7fd19@ernst.home>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8/16/19 3:05 AM, Gary Jennejohn wrote:
> I tried to build a kernel today and it failed in modules-all even
> though I had LOCAL_MODULES="" in /etc/src.conf, as recommended by
> jhb.
>
> That's wrong. It has to be LOCAL_MODULES=, otherwise
> /sys/conf/kern.post.mk seems to conclude that there should be a
> module under /usr/local/sys/modules with the name "".
I think this will permit both versions to work:
Index: sys/conf/kern.post.mk
===================================================================
--- kern.post.mk (revision 351151)
+++ kern.post.mk (working copy)
@@ -76,6 +76,7 @@ modules-${target}:
cd $S/modules; ${MKMODULESENV} ${MAKE} \
${target:S/^reinstall$/install/:S/^clobber$/cleandir/}
.endif
+.if !empty(LOCAL_MODULES)
.for module in ${LOCAL_MODULES}
@${ECHODIR} "===> ${module} (${target:S/^reinstall$/install/:S/^clobber$/cleandir/})"
@cd ${LOCAL_MODULES_DIR}/${module}; ${MKMODULESENV} ${MAKE} \
@@ -83,6 +84,7 @@ modules-${target}:
${target:S/^reinstall$/install/:S/^clobber$/cleandir/}
.endfor
.endif
+.endif
.endfor
# Handle ports (as defined by the user) that build kernel modules
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e1010b9b-26a6-9ce6-873c-10e503dc2030>