Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 9 Feb 2009 16:53:37 +0000 (UTC)
From:      Max Khon <fjoe@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r188392 - head/sys/pci
Message-ID:  <200902091653.n19GrbIB065499@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: fjoe
Date: Mon Feb  9 16:53:37 2009
New Revision: 188392
URL: http://svn.freebsd.org/changeset/base/188392

Log:
  Destroy TX tag outside of loop scope.
  
  Found with:	Coverity Prevent(tm)
  CID:		3886

Modified:
  head/sys/pci/if_rl.c

Modified: head/sys/pci/if_rl.c
==============================================================================
--- head/sys/pci/if_rl.c	Mon Feb  9 15:55:21 2009	(r188391)
+++ head/sys/pci/if_rl.c	Mon Feb  9 16:53:37 2009	(r188392)
@@ -1151,9 +1151,9 @@ rl_dma_free(struct rl_softc *sc)
 				    sc->rl_cdata.rl_tx_dmamap[i]);
 				sc->rl_cdata.rl_tx_dmamap[i] = NULL;
 			}
+		}
 		bus_dma_tag_destroy(sc->rl_cdata.rl_tx_tag);
 		sc->rl_cdata.rl_tx_tag = NULL;
-		}
 	}
 
 	if (sc->rl_parent_tag != NULL) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200902091653.n19GrbIB065499>