From owner-freebsd-bugs@freebsd.org Thu Jul 27 00:45:01 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D3685DB5072 for ; Thu, 27 Jul 2017 00:45:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C168682B6F for ; Thu, 27 Jul 2017 00:45:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v6R0j15U070481 for ; Thu, 27 Jul 2017 00:45:01 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 221039] uptime/w always show number of users in plural Date: Thu, 27 Jul 2017 00:45:01 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: timur@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jul 2017 00:45:01 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D221039 Bug ID: 221039 Summary: uptime/w always show number of users in plural Product: Base System Version: 11.0-STABLE Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: timur@FreeBSD.org I've noticed that even when there is only one logged in user in the sustem = the output of uptime/w shows: 2:35AM up 22 days, 9:09, 1 users, load averages: 0.26, 0.24, 0.24 For the FreeBSD 10-STABLE and before it used to be: 12:37AM up 63 days, 12:20, 1 user, load averages: 0.21, 0.14, 0.09 A short dive into the code exposed, that now this output is generated by li= bxo, which is nice, but has more cumbersome syntax: /* Print number of users logged in to system */ xo_emit(" {:users/%d} {N:user%s}", nusers, nusers =3D=3D 1 ? "" : "= s"); Apparenty, for the labels ({N:}) sprintf-like expressions don't work and % = sign is just removed from the label, making label to be always "users". The proper way to express plurals with-in libxo should be: xo_emit(" {:users/%d} {Ngp:user,users}", nusers); according to the http://juniper.github.io/libxo/libxo-manual.html#plural-modifier That handles nusers properly: 0 users 1 user 2 users 101 users In addition, libxo'thication could help with https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D219113 as well. --=20 You are receiving this mail because: You are the assignee for the bug.=