From owner-svn-src-all@FreeBSD.ORG  Sun Jan 18 10:11:49 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9FB691065675
	for <svn-src-all@freebsd.org>; Sun, 18 Jan 2009 10:11:49 +0000 (UTC)
	(envelope-from christoph.mallon@gmx.de)
Received: from mail.gmx.net (mail.gmx.net [213.165.64.20])
	by mx1.freebsd.org (Postfix) with SMTP id E02258FC14
	for <svn-src-all@freebsd.org>; Sun, 18 Jan 2009 10:11:48 +0000 (UTC)
	(envelope-from christoph.mallon@gmx.de)
Received: (qmail invoked by alias); 18 Jan 2009 10:11:47 -0000
Received: from p54A3EF46.dip.t-dialin.net (EHLO tron.homeunix.org)
	[84.163.239.70]
	by mail.gmx.net (mp015) with SMTP; 18 Jan 2009 11:11:47 +0100
X-Authenticated: #1673122
X-Provags-ID: V01U2FsdGVkX1/zoXt63iHzubKtbb6Wabbc68qGezfkVzKXSwTKmq
	I98VV78zDHLOCD
Message-ID: <49730062.2010900@gmx.de>
Date: Sun, 18 Jan 2009 11:11:46 +0100
From: Christoph Mallon <christoph.mallon@gmx.de>
User-Agent: Thunderbird 2.0.0.19 (X11/20090103)
MIME-Version: 1.0
To: Garrett Cooper <yanefbsd@gmail.com>
References: <200901172301.n0HN1ePm054707@svn.freebsd.org>
	<7d6fde3d0901180146v4fe098abmd526e2a2c869282b@mail.gmail.com>
In-Reply-To: <7d6fde3d0901180146v4fe098abmd526e2a2c869282b@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Y-GMX-Trusted: 0
X-FuHaFi: 0.57
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Ed Schouten <ed@freebsd.org>
Subject: Re: svn commit: r187374 - head/sys/dev/syscons/teken
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Jan 2009 10:11:50 -0000

Garrett Cooper schrieb:
> On Sat, Jan 17, 2009 at 3:01 PM, Ed Schouten <ed@freebsd.org> wrote:
> 
> [...]
> 
>> Modified:
>>  head/sys/dev/syscons/teken/teken_subr_compat.h
>>
>> Modified: head/sys/dev/syscons/teken/teken_subr_compat.h
>> ==============================================================================
>> --- head/sys/dev/syscons/teken/teken_subr_compat.h      Sat Jan 17 22:53:53 2009        (r187373)
>> +++ head/sys/dev/syscons/teken/teken_subr_compat.h      Sat Jan 17 23:01:40 2009        (r187374)
>> @@ -33,20 +33,23 @@ teken_subr_cons25_set_cursor_type(teken_
>>        teken_funcs_param(t, TP_SHOWCURSOR, type != 1);
>>  }
> 
> [...]
> 
> Dumb question:
> 
> Why are C function definitions in a .h file? I know it's legal, but at
> least from what I've been coached on in the past, it isn't necessarily
> the most kosher way of solving the issue.
> 
> Macros are a different point.

This is just a one-time include. I guess Ed used the .h suffix so his 
$EDITOR chooses the right syntax highlighting. There is some magic going 
on to call these functions (you probably noticed he didn't add any 
obvious callers): The callers are generated by a script. The differnt 
parts are then all included in teken.c.