From owner-svn-src-all@FreeBSD.ORG  Sun Jul 25 15:36:12 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 338851065670;
	Sun, 25 Jul 2010 15:36:12 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from mail06.syd.optusnet.com.au (mail06.syd.optusnet.com.au
	[211.29.132.187])
	by mx1.freebsd.org (Postfix) with ESMTP id C8D9D8FC0C;
	Sun, 25 Jul 2010 15:36:11 +0000 (UTC)
Received: from c122-106-147-41.carlnfd1.nsw.optusnet.com.au
	(c122-106-147-41.carlnfd1.nsw.optusnet.com.au [122.106.147.41])
	by mail06.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	o6PFa7TC023522
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Mon, 26 Jul 2010 01:36:08 +1000
Date: Mon, 26 Jul 2010 01:36:07 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@delplex.bde.org
To: Stefan Farfeleder <stefanf@freebsd.org>
In-Reply-To: <20100724183732.GA1715@mole.fafoe.narf.at>
Message-ID: <20100726013202.G11808@delplex.bde.org>
References: <201007241814.o6OIEY4K099556@svn.freebsd.org>
	<20100724183732.GA1715@mole.fafoe.narf.at>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Konstantin Belousov <kib@freebsd.org>
Subject: Re: svn commit: r210451 - head/sys/sys
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Jul 2010 15:36:12 -0000

On Sat, 24 Jul 2010, Stefan Farfeleder wrote:

> declaring enums like this is not standard C code (seems to be a GCC
> extension). I don't think we should use this feature in our headers.

This is unfortunate.  This is because the size of an enum variable
depends on its complete declaration.  This is an error unconditionaly
with TenDRA.  It takes -pedantic to get a warning from gcc.

>> Modified: head/sys/sys/imgact.h
>> ==============================================================================
>> --- head/sys/sys/imgact.h	Sat Jul 24 18:05:10 2010	(r210450)
>> +++ head/sys/sys/imgact.h	Sat Jul 24 18:14:34 2010	(r210451)
>> @@ -32,8 +32,6 @@
>>  #ifndef _SYS_IMGACT_H_
>>  #define	_SYS_IMGACT_H_
>>
>> -#include <sys/uio.h>
>> -

The rule that new pollution may not be added to old headers should have
prevented the need for this removal.

>>  #define MAXSHELLCMDLEN	PAGE_SIZE
>>
>>  struct image_args {
>> @@ -75,6 +73,7 @@ struct image_params {
>>  #ifdef _KERNEL
>>  struct sysentvec;
>>  struct thread;
>> +enum uio_seg;
>>
>>  #define IMGACT_CORE_COMPRESS	0x01

Bruce