Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 13 May 2016 08:04:03 +0000 (UTC)
From:      Garrett Cooper <ngie@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-9@freebsd.org
Subject:   svn commit: r299614 - stable/9/sys/kern
Message-ID:  <201605130804.u4D843dG055407@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ngie
Date: Fri May 13 08:04:03 2016
New Revision: 299614
URL: https://svnweb.freebsd.org/changeset/base/299614

Log:
  MFstable/10 r299613:
  
  MFC r298678:
  r298678 (by cem):
  
  posix4_mib: Don't overrun facility_initialized array
  
  The facility_initialized and facility arrays are the same size and were
  intended to be indexed the same.  I believe this mismatch was just a
  typo/braino in r208731.
  
  CID:		1017430

Modified:
  stable/9/sys/kern/posix4_mib.c
Directory Properties:
  stable/9/   (props changed)
  stable/9/sys/   (props changed)

Modified: stable/9/sys/kern/posix4_mib.c
==============================================================================
--- stable/9/sys/kern/posix4_mib.c	Fri May 13 07:56:14 2016	(r299613)
+++ stable/9/sys/kern/posix4_mib.c	Fri May 13 08:04:03 2016	(r299614)
@@ -114,9 +114,9 @@ p31b_sysctl_proc(SYSCTL_HANDLER_ARGS)
 	num = arg2;
 	if (!P31B_VALID(num))
 		return (EINVAL);
-	val = facility_initialized[num] ? facility[num - 1] : 0;
+	val = facility_initialized[num - 1] ? facility[num - 1] : 0;
 	error = sysctl_handle_int(oidp, &val, 0, req);
-	if (error == 0 && req->newptr != NULL && facility_initialized[num])
+	if (error == 0 && req->newptr != NULL && facility_initialized[num - 1])
 		facility[num - 1] = val;
 	return (error);
 }
@@ -138,7 +138,7 @@ p31b_unsetcfg(int num)
 {
 
 	facility[num - 1] = 0;
-	facility_initialized[num -1] = 0;
+	facility_initialized[num - 1] = 0;
 }
 
 int



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201605130804.u4D843dG055407>