From owner-svn-src-head@freebsd.org Tue Mar 31 02:55:21 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CAF55273D06; Tue, 31 Mar 2020 02:55:21 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48rv7l22Vdz48JH; Tue, 31 Mar 2020 02:54:58 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-io1-xd35.google.com with SMTP id b12so3956389ion.8; Mon, 30 Mar 2020 19:54:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RIBTpf3eCZ5OB7cP9Rcxkkw7xjAbDYrW49M/oMRmTwo=; b=e4uRO5lL2gkqVmT7ptuV3uU68kI0/yZqXKbT0ro4U918GMoiRefvFgCex2Ls/u4iAj aa0R8V3uAa/yBZChhBT4io6meCaeGHI06i8bShBmP8qMci37J9H+o1SK/qMcNkPsnUVi Gg3/3MxC8lDSHphIP9UmTIzkiMLOnp6s4zaozwsSz25qodCA1RwnXhYqV6IB5FpXxIP2 H6DPwUlQGhCMfCDWu5gs+vIC99eGhrX8JD+r1dvbhYWKJ90Ag0IJl7H2zxEHA/Usge8V XwY0TiYtGQRW4QENpFaCi+h9pOf/XxykBZ21SMXQNJmY3D6cJBoXaVz2z6qW8H0y35VK 3dZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=RIBTpf3eCZ5OB7cP9Rcxkkw7xjAbDYrW49M/oMRmTwo=; b=nmOwLGXR+8LIbVBMSBhUfT2eiUy+h6a2Opc1CBOBl6EkMYsGs3Gq6haiNslDmCzW4x k/d66Abr3IYs9tfqCj5z/sdkw4F78WdPhiGNsmt+v62ebjRpjRKAadbJAc5NYBGPbIhm qxdPxVjlwnawPG1pVc79HopheiBu3H11Hem3bP5zu45Rdm16O5IUH44acPiA07j4IV+3 5Na9+agxmENhHawvBlnhsm15Qs3uG2nVthHz2+KYXSNMi4LEqtOeAFAlLrz/6FMXmGSu XBCfLowH5Jafl9ENxmcmdav+yNTJzj8uBZvia+r3+Hz92TQ4i3CSRtGEQYAemeIu8kEC 018Q== X-Gm-Message-State: ANhLgQ2OXacQPz3JntbMQnh0TEVYCBQeWXW15YlMF2CQj16IyTezHlst JXOtMduN2XueGUw0jmynJcuHF52L X-Google-Smtp-Source: ADFU+vsybWqg6UYXBMdefKqtw6z52tlpmBH34eIIC8V6hagRbdZa09WAbXEggS/qIGWJGvp/WxGWDA== X-Received: by 2002:ac8:1b2f:: with SMTP id y44mr3066299qtj.25.1585621892734; Mon, 30 Mar 2020 19:31:32 -0700 (PDT) Received: from raichu (toroon0560w-lp130-10-174-94-17-182.dsl.bell.ca. [174.94.17.182]) by smtp.gmail.com with ESMTPSA id d2sm11766605qkl.98.2020.03.30.19.31.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 19:31:32 -0700 (PDT) Sender: Mark Johnston Date: Mon, 30 Mar 2020 22:31:27 -0400 From: Mark Johnston To: Li-Wen Hsu Cc: src-committers , svn-src-all , svn-src-head Subject: Re: svn commit: r359436 - in head/sys: kern net sys Message-ID: <20200331023127.GA97238@raichu> References: <202003301422.02UEMrxL059978@repo.freebsd.org> <20200331015905.GC65028@raichu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200331015905.GC65028@raichu> X-Rspamd-Queue-Id: 48rv7l22Vdz48JH X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=e4uRO5lL; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::d35 as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-3.16 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-1.46)[ip: (-6.46), ipnet: 2607:f8b0::/32(-0.35), asn: 15169(-0.45), country: US(-0.05)]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_IN_DNSWL_NONE(0.00)[5.3.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MID_RHS_NOT_FQDN(0.50)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Mar 2020 02:55:22 -0000 On Mon, Mar 30, 2020 at 09:59:05PM -0400, Mark Johnston wrote: > On Tue, Mar 31, 2020 at 09:40:51AM +0800, Li-Wen Hsu wrote: > > On Mon, Mar 30, 2020 at 10:32 PM Mark Johnston wrote: > > > > > > Author: markj > > > Date: Mon Mar 30 14:22:52 2020 > > > New Revision: 359436 > > > URL: https://svnweb.freebsd.org/changeset/base/359436 > > > > > > Log: > > > Simplify taskqgroup inititialization. > > > > > > taskqgroup initialization was broken into two steps: > > > > > > 1. allocate the taskqgroup structure, at SI_SUB_TASKQ; > > > 2. initialize taskqueues, start taskqueue threads, enqueue "binder" > > > tasks to bind threads to specific CPUs, at SI_SUB_SMP. > > > > > > Step 2 tries to handle the case where tasks have already been attached > > > to a queue, by migrating them to their intended queue. In particular, > > > tasks can't be enqueued before step 2 has completed. This breaks NFS > > > mountroot on systems using an iflib-based driver when EARLY_AP_STARTUP > > > is not defined, since mountroot happens before SI_SUB_SMP in this case. > > > > > > Simplify initialization: do all initialization except for CPU binding at > > > SI_SUB_TASKQ. This means that until CPU binding is completed, group > > > tasks may be executed on a CPU other than that to which they were bound, > > > but this should not be a problem for existing users of the taskqgroup > > > KPIs. > > > > > > Reported by: sbruno > > > Tested by: bdragon, sbruno > > > MFC after: 1 month > > > Sponsored by: The FreeBSD Foundation > > > Differential Revision: https://reviews.freebsd.org/D24188 > > > > > > Modified: > > > head/sys/kern/subr_gtaskqueue.c > > > head/sys/net/iflib.c > > > head/sys/sys/gtaskqueue.h > > > > Hi Mark, > > > > I see many "panic: deadlres_td_sleep_q: possible deadlock detected" in > > the CI after this commit: > > > > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14738/consoleFull > > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14739/consoleFull > > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14741/consoleFull > > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14742/consoleFull > > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14743/console > > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14744/consoleFull > > > > It seems could be triggered by sys.netinet6.frag6.* > > sys.netpfil.common.* sbin.pfctl.pfctl_test.* tests, and there are lots > > of test cases timed out. > > > > Can you help check these? > > I see, it is actually caused by r359438. I'm looking at it now. I verified that the netpfil and netinet6 tests pass with r359477.