Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 24 Aug 2009 20:37:15 +0000 (UTC)
From:      Pyun YongHyeon <yongari@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r196517 - head/sys/dev/alc
Message-ID:  <200908242037.n7OKbFuW005732@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: yongari
Date: Mon Aug 24 20:37:15 2009
New Revision: 196517
URL: http://svn.freebsd.org/changeset/base/196517

Log:
  Don't try to power down PHY when alc(4) failed to map the device.
  This fixes system crash when mapping alc(4) device failed in device
  attach.
  
  Reported by:	Jim < stapleton.41 <> gmail DOT com >
  MFC after:	3 days

Modified:
  head/sys/dev/alc/if_alc.c

Modified: head/sys/dev/alc/if_alc.c
==============================================================================
--- head/sys/dev/alc/if_alc.c	Mon Aug 24 18:58:13 2009	(r196516)
+++ head/sys/dev/alc/if_alc.c	Mon Aug 24 20:37:15 2009	(r196517)
@@ -858,7 +858,8 @@ alc_detach(device_t dev)
 			sc->alc_intrhand[i] = NULL;
 		}
 	}
-	alc_phy_down(sc);
+	if (sc->alc_res[0] != NULL)
+		alc_phy_down(sc);
 	bus_release_resources(dev, sc->alc_irq_spec, sc->alc_irq);
 	if ((sc->alc_flags & (ALC_FLAG_MSI | ALC_FLAG_MSIX)) != 0)
 		pci_release_msi(dev);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200908242037.n7OKbFuW005732>