Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 27 Apr 1996 09:41:33 -0700
From:      John Polstra <jdp@polstra.com>
To:        ache@astral.msk.su, phk@critter.tfs.com
Cc:        joerg_wunsch@uriah.heep.sax.de, current@FreeBSD.ORG
Subject:   Re: local router<->router UDP traffic: log_in_vain stuff error
Message-ID:  <199604271641.JAA15176@austin.polstra.com>
In-Reply-To: <199604271209.QAA07239@astral.msk.su>

next in thread | previous in thread | raw e-mail | index | archive | help
> > Uhm this doesn't make any sense to me, the log_in_vain change was the
> > addition of this bit of code:
> > 
> >                 if (log_in_vain)
> >                         log(LOG_INFO, "Connection attempt to UDP %s:%d"
> >                             " from %s:%d\n",
> >                                 inet_ntoa(ip->ip_dst), ntohs(uh->uh_dport),
> >                                 inet_ntoa(ip->ip_src), ntohs(uh->uh_sport));
> > 
> 
> Maybe ip->ip_src not properly evaluated there.

Inet_ntoa formats its result into a static buffer.  It doesn't work to
have two calls to it in a single expression.
--
   John Polstra                                       jdp@polstra.com
   John D. Polstra & Co., Inc.                Seattle, Washington USA
   "Self-knowledge is always bad news."                 -- John Barth



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199604271641.JAA15176>