Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 16 Apr 2013 15:41:09 +0200
From:      Tijl Coosemans <tijl@FreeBSD.org>
To:        Tim Kientzle <kientzle@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r249484 - head/lib
Message-ID:  <516D54F5.4010501@FreeBSD.org>
In-Reply-To: <201304141913.r3EJDqPI095965@svn.freebsd.org>
References:  <201304141913.r3EJDqPI095965@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
------enig2NLKUGFSIRFVEBONHBTKX
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 2013-04-14 21:13, Tim Kientzle wrote:
> Author: kientzle
> Date: Sun Apr 14 19:13:51 2013
> New Revision: 249484
> URL: http://svnweb.freebsd.org/changeset/base/249484
>=20
> Log:
>   Install a symlink
>     /usr/lib/include =3D=3D> /usr/include
>  =20
>   This fixes -print-file-name=3Dinclude in clang (and is
>   arguably a better way to fix the same issue in GCC than
>   the change I made in r231336).
>  =20
>   MFC after:	1 week
>=20
> Modified:
>   head/lib/Makefile
>=20
> Modified: head/lib/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/lib/Makefile	Sun Apr 14 18:36:30 2013	(r249483)
> +++ head/lib/Makefile	Sun Apr 14 19:13:51 2013	(r249484)
> @@ -252,4 +252,7 @@ _libusbhid=3D	libusbhid
>  _libusb=3D	libusb
>  .endif
> =20
> +afterinstall:
> +	ln -fs ../include ${DESTDIR}/usr/lib/include
> +
>  .include <bsd.subdir.mk>

This breaks with -DNO_CLEAN defined, because then
${DESTDIR}/usr/lib/include/include is created.

I'm not that fond of this patch by the way, but I don't fully
understand the problem it's trying to solve so I won't object.
It just looks too much like a hack to me.


------enig2NLKUGFSIRFVEBONHBTKX
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iF4EAREIAAYFAlFtVPsACgkQfoCS2CCgtisXIAD/S3CqiTuMctYwQ10yBQ9nzdtZ
KBdjA2SEatk1Bky9z/sA/2UUL4besuqrSrzMhidDevnS+/Qvap3XfPuLu23UZl0M
=rC1m
-----END PGP SIGNATURE-----

------enig2NLKUGFSIRFVEBONHBTKX--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?516D54F5.4010501>