Date: Mon, 05 Jan 2009 14:52:33 -0800 From: Sam Leffler <sam@freebsd.org> To: Christoph Mallon <christoph.mallon@gmx.de> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, "Bjoern A. Zeeb" <bz@freebsd.org>, src-committers@freebsd.org, Steve Kargl <sgk@troutmask.apl.washington.edu> Subject: Re: svn commit: r186751 - in head/sys: netinet6 netipsec Message-ID: <49628F31.5040606@freebsd.org> In-Reply-To: <49627592.60208@gmx.de> References: <200901042153.n04LrgkD075147@svn.freebsd.org> <20090104220716.GL14235@hoeg.nl> <alpine.BSF.2.00.0901042213530.67103@fledge.watson.org> <20090105172400.T45399@maildrop.int.zabbadoz.net> <49624DB9.8080900@gmx.de> <20090105194210.P45399@maildrop.int.zabbadoz.net> <20090105204356.GA52934@troutmask.apl.washington.edu> <49627592.60208@gmx.de>
next in thread | previous in thread | raw e-mail | index | archive | help
Christoph Mallon wrote:
> Steve Kargl schrieb:
>> Stylistic changes (including whitespace changes) are hard on
>> the source repository and are to be avoided without good reason.
>
> Yet another anachronism in style(9).
> (Does that sentence even mean what I think it means? Somehow it sounds
> like "there is no good reason, but avoid them anyway" instead of
> "avoid them if you have no good reason".)
>
>
And for the N'th time I will say: style is guideline and not a
contract. The day people arbitrarily change code simply because some
cabal decided where spaces should go is the day people will stop
contributing. It's all fine and well to make style consistent when
you're working in an area of the code (and can verify your changes) but
knob polishing is just code churn and in my experience is
counter-productive. Spend your time and effort on fixing real problems;
god knows we've got enough of 'em...
Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49628F31.5040606>