Date: Mon, 12 Dec 2016 17:33:54 -0500 From: "Kenneth D. Merry" <ken@FreeBSD.ORG> To: Oliver Pinter <oliver.pinter@hardenedbsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r307684 - head/sbin/camcontrol Message-ID: <20161212223354.GA16028@mithlond.kdm.org> In-Reply-To: <CAPQ4ffvpCmQmo2qwdmeNqdOAKZxieq5BAdptvtmT58nu2oMdqQ@mail.gmail.com> References: <201610201942.u9KJgQOR062772@repo.freebsd.org> <CAPQ4ffvpCmQmo2qwdmeNqdOAKZxieq5BAdptvtmT58nu2oMdqQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Dec 11, 2016 at 00:49:12 +0100, Oliver Pinter wrote: > On 10/20/16, Kenneth D. Merry <ken@freebsd.org> wrote: > > Author: ken > > Date: Thu Oct 20 19:42:26 2016 > > New Revision: 307684 > > URL: https://svnweb.freebsd.org/changeset/base/307684 > > > > Log: > > For CCBs allocated on the stack, we need to clear the entire CCB, not > > just > > the header. Otherwise stack garbage can lead to random flags getting > > set. > > > > This showed up as 'camcontrol rescan all' failing with EINVAL because the > > address type wasn't CAM_DATA_VADDR. > > > > sbin/camcontrol/camcontrol.c: > > In rescan_or_reset_bus(), bzero the stack-allocated CCBs before > > use instead of clearing the body. > > > > MFC after: 3 days > > Sponsored by: Spectra Logic > > The MFC of this commit is missed both for 10-STABLE and 11-STABLE. Is > this still in plan to do? Done, thanks for the reminder! Ken -- Kenneth Merry ken@FreeBSD.ORG
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161212223354.GA16028>