From owner-freebsd-bugs Fri May 26 7:54:41 2000 Delivered-To: freebsd-bugs@freebsd.org Received: from MailAndNews.com (MailAndNews.com [199.29.68.160]) by hub.freebsd.org (Postfix) with ESMTP id E6C1837BDBE for ; Fri, 26 May 2000 07:54:32 -0700 (PDT) (envelope-from mheffner@mailandnews.com) Received: from muriel.penguinpowered.com [208.138.198.109] (mheffner@mailandnews.com); Fri, 26 May 2000 10:54:14 -0400 X-WM-Posted-At: MailAndNews.com; Fri, 26 May 00 10:54:14 -0400 Content-Length: 1020 Message-ID: X-Mailer: XFMail 1.4.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200005260613.PAA29126@astemfs.astem.or.jp> Date: Fri, 26 May 2000 10:51:55 -0400 (EDT) Reply-To: Mike Heffner From: Mike Heffner To: Kenji Yabuuchi Subject: Re: kern/18526: mx does not receive ethernet broadcast packet Cc: freebsd-bugs@FreeBSD.ORG, Gregory Bond Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On 26-May-2000 Kenji Yabuuchi wrote: | >>>>> On Fri, 26 May 2000 15:52:35 +1000, Gregory Bond | >>>>> said: | >> + if (t->mx_did == MX_DEVICEID_987x5) | >> + if (rev != MX_REVISION_98715AEC) | >> + t++; | >> + else if (rev >= MX_REVISION_98725) | >> + t++; | |> Either I'm dense or this is not right (or at the very least, wildly | |> redundant). | |> if (rev != a) t++; | |> else if (rev >= b) t++; | |> makes no sense when a & b are constant. | | Yes, you're right. This part should be: | | if (rev != MX_REVISION_98715AEC || rev >= MX_REVISION_98725) | t++; Could the "rev >= MX_REVISION_98725" be replaced with "MX_REVISION_98715AEC >= MX_REVISION_98725", which would be optimized by the compiler ahead of time. - Mike Heffner Fredericksburg, VA ICQ# 882073 http://my.ispchannel.com/~mheffner - To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message