From owner-freebsd-hackers  Fri Apr  5  5:39:16 2002
Delivered-To: freebsd-hackers@freebsd.org
Received: from mailgate.rz.uni-karlsruhe.de (mailgate.rz.uni-karlsruhe.de [129.13.64.97])
	by hub.freebsd.org (Postfix) with ESMTP id 0ADD237B416
	for <freebsd-hackers@freebsd.org>; Fri,  5 Apr 2002 05:39:09 -0800 (PST)
Received: from rzstud1.rz.uni-karlsruhe.de (rzstud1.rz.uni-karlsruhe.de [193.196.41.33])
	by mailgate.rz.uni-karlsruhe.de with esmtp (Exim 3.33 #1)
	id 16tTvn-0002a5-00; Fri, 05 Apr 2002 15:39:07 +0200
Received: from un1i by rzstud1.rz.uni-karlsruhe.de with local (Exim 3.33 #1)
	id 16tTvt-0002NJ-00; Fri, 05 Apr 2002 15:39:13 +0200
From: Philipp Mergenthaler <un1i@rz.uni-karlsruhe.de>
To: freebsd-hackers@FreeBSD.ORG
Cc: maxim@macomnet.ru
Subject: Re: cdcontrol(1) speed command
X-Newsgroups: list.freebsd-hackers
In-Reply-To: <20020405145853.O45449-100000@news1.macomnet.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Message-Id: <E16tTvt-0002NJ-00@rzstud1.rz.uni-karlsruhe.de>
Date: Fri, 05 Apr 2002 15:39:13 +0200
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-hackers.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-hackers>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-hackers>
X-Loop: FreeBSD.ORG

In article <20020405145853.O45449-100000@news1.macomnet.ru> you wrote:

> Here is a patch for cdcontrol(1) to allow set maximum CD drive speed.
> It comes from kern/35512. Are there any comments/objections?


> Index: cdcontrol.1
> ===================================================================
> RCS file: /home/ncvs/src/usr.sbin/cdcontrol/cdcontrol.1,v
> retrieving revision 1.32
> diff -u -r1.32 cdcontrol.1
> --- cdcontrol.1	15 Jul 2001 08:01:46 -0000	1.32
> +++ cdcontrol.1	27 Mar 2002 10:57:34 -0000
> @@ -154,6 +154,9 @@
>  Set minute-second-frame ioctl mode (default).
>  .It Cm set Ar lba
>  Set LBA ioctl mode.
> +.It Cm speed Ar s
> +Set the highest speed that the drive should use. This command is currently
> +only supported on ATAPI drives.

Maybe we should mention the unit for speed here, i.e. "kB/s" or
"multiples of single speed", but that depends on whether kern/35512
will be accepted or not.

[...]
> +++ cdcontrol.c	27 Mar 2002 10:58:12 -0000
> @@ -24,6 +24,7 @@
>  #endif /* not lint */

>  #include <sys/cdio.h>
> +#include <sys/cdrio.h>

Jörg Wunsch commented that adding "include <sys/cdrio.h>" would be
wrong and that this ioctl should be moved to sys/cdio.h instead.
(I guess then it should be renamed to CDIOCREADSPEED, too.)
This would then have to be changed in src/sys/dev/ata/atapi-cd.c, too.

Bye, Philipp

-- 
http://www.uni-karlsruhe.de/~un1i/                          (,.)
                                                          \\\@@ )
                                                            \= )
                                                            cc_|\_,^

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message